[issue12880] ctypes: clearly document how structure bit fields are allocated

2011-10-04 Thread Vlad Riscutia
Vlad Riscutia riscutiav...@gmail.com added the comment: Thanks for the make patchcheck tip, I didn't know about that. I will update the patch soon. In the mean time, I want to point out a couple of things: First, I'm saying toying with the underlying buffer because none of the bugs are actual

[issue12880] ctypes: clearly document how structure bit fields are allocated

2011-10-04 Thread Meador Inge
Meador Inge mead...@gmail.com added the comment: On Tue, Oct 4, 2011 at 10:21 AM, Vlad Riscutia rep...@bugs.python.org wrote: First, I'm saying toying with the underlying buffer because none of the bugs are actual issues of the form I created this bitfield structure with Python, passed it

[issue12880] ctypes: clearly document how structure bit fields are allocated

2011-10-04 Thread Meador Inge
Meador Inge mead...@gmail.com added the comment: Look in 'cfield.c' where all of the native alignments Well, not *all* the native alignments, but many of them. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12880

[issue12880] ctypes: clearly document how structure bit fields are allocated

2011-10-04 Thread Vlad Riscutia
Vlad Riscutia riscutiav...@gmail.com added the comment: I agree compiler matters for alignment but if you look at PyCField_FromDesc, you will see the layout is pretty much #ifdef MS_WIN32 - #else. Sorry for generalizing, all indeed is not the right word. My point is that we should set

[issue12880] ctypes: clearly document how structure bit fields are allocated

2011-10-04 Thread Terry J. Reedy
Terry J. Reedy tjre...@udel.edu added the comment: If I understand correctly, this doc patch would apply to 2.7 and 3.2 also. I have two style comments. I believe It is important to note that bit field allocation and layout in memory is not defined as a standard, rather its implementation is

[issue12880] ctypes: clearly document how structure bit fields are allocated

2011-10-03 Thread Meador Inge
Meador Inge mead...@gmail.com added the comment: On Fri, Sep 30, 2011 at 12:19 PM, Vlad Riscutia rep...@bugs.python.org wrote: I believe this is the better thing to do rather than detailing how GCC and MSVC allocated their bitfields because that would just encourage people to use this

[issue12880] ctypes: clearly document how structure bit fields are allocated

2011-10-03 Thread Meador Inge
Meador Inge mead...@gmail.com added the comment: Added some comments in rietveld. P.S. watch out for trailing whitespace when writing patches. Use 'make patchcheck' to help find bad whitespace formatting. -- ___ Python tracker

[issue12880] ctypes: clearly document how structure bit fields are allocated

2011-09-30 Thread Vlad Riscutia
Vlad Riscutia riscutiav...@gmail.com added the comment: Attached doc update against tip (though I still hope my patch for configurable allocation strategies will make it in). This is my first doc patch so let me know if I missed something. I am basically explaining that bit field allocation

[issue12880] ctypes: clearly document how structure bit fields are allocated

2011-09-10 Thread Meador Inge
Meador Inge mead...@gmail.com added the comment: Another example of desperately needed documentation: issue12945. -- components: +ctypes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12880

[issue12880] ctypes: clearly document how structure bit fields are allocated

2011-09-01 Thread Meador Inge
New submission from Meador Inge mead...@gmail.com: As issues like issue6069 and issue11920 allude to, figuring out how 'ctypes' allocates bit-fields is not very clear. The documentation should be enhanced to flesh this out in more detail. As an example, Microsoft documents the VC++