[issue13096] ctypes: segfault with large POINTER type names

STINNER Victor added the comment: New changeset 710dcfd2f4bee034894a39026388f9c21ea976f1 by Victor Stinner (stratakis) in branch '2.7': [2.7] bpo-13096: Fix memory leak in ctypes POINTER handling of large values (GH-12100)

[issue13096] ctypes: segfault with large POINTER type names

Change by Charalampos Stratakis : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13096] ctypes: segfault with large POINTER type names

Charalampos Stratakis added the comment: It seems the python2 backport was incomplete as a PyMem_Free is missing, making buf leak. -- nosy: +cstratak ___ Python tracker ___

[issue13096] ctypes: segfault with large POINTER type names

Change by Charalampos Stratakis : -- pull_requests: +12107 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13096] ctypes: segfault with large POINTER type names

Roundup Robot added the comment: New changeset e940bb13d010 by R David Murray in branch '3.4': #13096: Fix segfault in CTypes POINTER handling of large values. https://hg.python.org/cpython/rev/e940bb13d010 New changeset 02c9c3204a04 by R David Murray in branch 'default': Merge: #13096: Fix

[issue13096] ctypes: segfault with large POINTER type names

R. David Murray added the comment: Committed. -- nosy: +r.david.murray resolution: - fixed stage: commit review - resolved status: open - closed versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13096

[issue13096] ctypes: segfault with large POINTER type names

Meador Inge added the comment: Thanks for the review and reminder about this issue, jesstess. I will apply the patch later today. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13096 ___

[issue13096] ctypes: segfault with large POINTER type names

Jessica McKellar added the comment: Thanks for the report and patch, meador.inge. I'd prefer not to add more globals that are only used in one place, but doing so is consistent with the existing style of test_pointers.py, and there's plenty in this file that could be cleaned up in another

[issue13096] ctypes: segfault with large POINTER type names

Changes by Meador Inge mead...@gmail.com: -- assignee: - meador.inge ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13096 ___ ___ Python-bugs-list

[issue13096] ctypes: segfault with large POINTER type names

Meador Inge mead...@gmail.com added the comment: Here is a small patch against tip. OK? -- keywords: +patch stage: needs patch - patch review Added file: http://bugs.python.org/file23800/issue13096.patch ___ Python tracker rep...@bugs.python.org

[issue13096] ctypes: segfault with large POINTER type names

Brian Brazil brian.bra...@gmail.com added the comment: The problem is around line 1734 of callproc.c in tip: } else if (PyType_Check(cls)) { typ = (PyTypeObject *)cls; buf = alloca(strlen(typ-tp_name) + 3 + 1); sprintf(buf, LP_%s, typ-tp_name); -- segfault is here

[issue13096] ctypes: segfault with large POINTER type names

Meador Inge mead...@gmail.com added the comment: Yup, it is the 'alloca' call. This issue and issue13097 are both 'alloca' related as mentioned in issue12881. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13096

[issue13096] ctypes: segfault with large POINTER type names

New submission from Meador Inge mead...@gmail.com: Reproducible in 2.7 and tip: [meadori@motherbrain cpython]$ ./python Python 3.3.0a0 (default:61de28fa5537+d05350c14e77+, Oct 3 2011, 21:47:04) [GCC 4.6.0 20110603 (Red Hat 4.6.0-10)] on linux Type help, copyright, credits or license for more

[issue13096] ctypes: segfault with large POINTER type names

Meador Inge mead...@gmail.com added the comment: There is similar crasher to this one that can be reproduced like: [meadori@motherbrain cpython]$ ./python Python 3.3.0a0 (default:61de28fa5537+d05350c14e77+, Oct 3 2011, 21:47:04) [GCC 4.6.0 20110603 (Red Hat 4.6.0-10)] on linux Type help,