Roundup Robot added the comment:
New changeset 779de7b4909b by Serhiy Storchaka in branch '2.7':
Issue #13107: argparse and optparse no longer raises an exception when output
http://hg.python.org/cpython/rev/779de7b4909b
New changeset c6c30b682e14 by Serhiy Storchaka in branch '3.3':
Issue
Serhiy Storchaka added the comment:
Thank you Adam for your report. Thank you Elazar for your patch.
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Serhiy Storchaka added the comment:
Here is less ugly patch (for argparse and optparse). Instead of prohibiting
wrapping at all for small width, it limits minimal width of formatted text. It
try first decrease the indent for help.
--
stage: test needed - patch review
Added file:
Elazar Gershuni added the comment:
ok. how about argparse_ugly.patch? below some width it simply won't do any
wrapping.
(I hadn't touch optparse yet)
--
Added file: http://bugs.python.org/file31731/argparse_ugly.patch
___
Python tracker
Dmi Baranov added the comment:
I think ugly look is better than silence here. Elazar, can you touch a
optparse too (with some tests - test.support.EnvironmentVarGuard context
manager will be helpful here)?
--
nosy: +dmi.baranov
___
Python tracker
Serhiy Storchaka added the comment:
I think ugly look is better than silence here.
Agree. We have two possibilities:
1. Decrease an indentation. There is a lot of blank spaces below option's names.
2. Set some minimal width (10 or 20 characters) and let lines wrap out.
For better look we
Elazar Gershuni added the comment:
I think in such case it is reasonable to fail silently, since the information
will not be readable anyway.
Is a patch like the attached acceptable? (Sorry, I am new here)
results:
import os, argparse; p = argparse.ArgumentParser(prog='PROG')
Serhiy Storchaka added the comment:
Yes, argparse has same problem.
import os, argparse
p = argparse.ArgumentParser(prog='PROG')
os.environ['COLUMNS'] = '16'
print(p.format_help())
Traceback (most recent call last):
File stdin, line 1, in module
File
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13107
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
keywords: +easy
stage: needs patch - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13107
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +aronacher, bethard
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13107
___
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
argparse has some similar code in Lib/argparse.py:489. Can you reproduce the
problem with argparse?
If you can't and argparse solved the problem already, we might adopt the same
solution; if you can, it should be fixed there too.
New submission from Adam Byrtek adambyr...@gmail.com:
Code snippet from optparse.py:
344 self.help_position = min(max_len + 2, self.max_help_position)
345 self.help_width = self.width - self.help_position
Where self.width is initialized with the COLUMNS environment
13 matches
Mail list logo
