[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

miss-islington added the comment: New changeset 5ca4fe04784fa278c319a3764c9a755f49cc0944 by Miss Islington (bot) in branch '3.7': bpo-13120: fix typo with test_issue13120() method name (GH-12250) https://github.com/python/cpython/commit/5ca4fe04784fa278c319a3764c9a755f49cc0944 --

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Change by miss-islington : -- pull_requests: +12582 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

miss-islington added the comment: New changeset 9139f926a8d8e5b71830cb7e10b0807836b5e9a4 by Miss Islington (bot) (Daniel Hahler) in branch 'master': bpo-13120: fix typo with test_issue13120() method name (GH-12250)

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

daniel hahler added the comment: Just for reference: there is a similar issue with `interaction`: https://bugs.python.org/issue36250. -- nosy: +blueyed ___ Python tracker

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Change by daniel hahler : -- pull_requests: +12238 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Stefan Krah added the comment: I think this commit broke the --without-threads buildbot: http://buildbot.python.org/all/builders/AMD64%20Fedora%20without%20threads%203.x/builds/3581/steps/test/logs/stdio -- nosy: +skrah ___ Python tracker

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Andrew Svetlov added the comment: Will take a look. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13120 ___ ___ Python-bugs-list mailing list

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Roundup Robot added the comment: New changeset 26056f8a0afe by Andrew Svetlov in branch '3.2': Skip pdb test for #13120 if threading is not available. http://hg.python.org/cpython/rev/26056f8a0afe New changeset 328a8824c1a7 by Andrew Svetlov in branch '3.3': Merge: skip pdb test for #13120 if

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Andrew Svetlov added the comment: Failed test is skipped if there are no threads. Thanks for report, Stefan! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13120 ___

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Roundup Robot added the comment: New changeset 708586792eec by Andrew Svetlov in branch '3.2': Issue #13120: Allow to call pdb.set_trace() from thread. http://hg.python.org/cpython/rev/708586792eec New changeset 678dba60c12d by Andrew Svetlov in branch '3.3': Merge issue #13120: Allow to call

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Andrew Svetlov added the comment: Fixed. Thanks. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13120

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

icemac added the comment: This bug bites me when developing with Pyramid using Python 3.2. I'd like to get it solved generally as the patch works for me (Python 3.2.3)). What needs to be done to get this patch into the version control system? -- nosy: +icemac

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13120 ___ ___

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Andrew Svetlov added the comment: Uploaded updated cumulative patch. Can we apply the patch to 3.2 or at least to 3.3? I see nothing wrong with it, but I'm ok with pushing to 3.4 only if we want to be extra careful. -- assignee: - asvetlov versions: +Python 3.4 Added file:

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Meador Inge mead...@gmail.com added the comment: Ilya, I agree. Thanks for the test patch. These two patches look OK to me. Georg OK with you? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13120

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Changes by Meador Inge mead...@gmail.com: -- nosy: +meador.inge ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13120 ___ ___ Python-bugs-list

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +georg.brandl stage: - patch review versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13120 ___

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Georg Brandl ge...@python.org added the comment: Patch seems fine to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13120 ___ ___

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Meador Inge mead...@gmail.com added the comment: Normally a test case is needed. I tried the following: diff --git a/Lib/test/test_pdb.py b/Lib/test/test_pdb.py --- a/Lib/test/test_pdb.py +++ b/Lib/test/test_pdb.py @@ -595,6 +595,25 @@ def test_pdb_run_with_code_object(): (Pdb) continue

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Ilya Sandler ilya.sand...@gmail.com added the comment: I think stuff like this can only be tested out-of-process. So I added an out-of-process test to test_pdb.py. The test passes with the fixed pdb.py. (and fails with the original one). Patch for the test attached. -- Added file:

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Ilya Sandler ilya.sand...@gmail.com added the comment: I confirm the bug. But I don't think disabling Ctrl-C (SIGINT) handling by default is a good idea. Proper Ctrl-C support seems like a fundamental feature for a command line debugger. However, I think the bug is easily fixable w/o

[issue13120] Default nosigint option to pdb.Pdb() prevents use in non-main thread

Changes by Ben Bass benb...@codedstructure.net: -- title: Default nosigint optionto pdb.Pdb() prevents use in non-main thread - Default nosigint option to pdb.Pdb() prevents use in non-main thread ___ Python tracker rep...@bugs.python.org