[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Berker Peksag added the comment: Thanks for the patch, Demian. I've simplified the test code a bit and committed it. Also, thanks for the report and for the initial patch Matt. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Roundup Robot added the comment: New changeset dfbd07cdc031 by Berker Peksag in branch 'default': Issue #13128: Print response headers for CONNECT requests when debuglevel > 0. https://hg.python.org/cpython/rev/dfbd07cdc031 -- nosy: +python-dev ___ Py

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Demian Brecht added the comment: New patch removes unrelated changes. -- Added file: http://bugs.python.org/file37892/issue13128_3.patch ___ Python tracker ___ __

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Demian Brecht added the comment: Sure, I should have some time later today to do so. Should such changes not be made as they're encountered in order to clean up the older code that isn't up to spec? Or should they only be made as the code is modified? On 2015-01-27 2:58 PM, Berker Peksag wrote:

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Berker Peksag added the comment: Thanks for the patch! Could you revert unrelated changes (whitespaces, PEP 8 etc.) if you have time? -- stage: patch review -> commit review ___ Python tracker

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Demian Brecht added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Demian Brecht added the comment: Just happened to come across this now. Updated patch with test. -- Added file: http://bugs.python.org/file37621/issue13128_2.patch ___ Python tracker ___

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Changes by Berker Peksag : -- nosy: +berker.peksag versions: +Python 3.5 -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list maili

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Demian Brecht added the comment: Attached a simple fix to the problem as written, matching logging method of HTTPResponse.begin(). -- nosy: +demian.brecht Added file: http://bugs.python.org/file36018/issue13128.patch ___ Python tracker

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Mark Lawrence added the comment: The httplib module has been renamed to http.client in Python 3, besides which the attached patch isn't in the standard format that is used here. -- nosy: +BreamoreBoy ___ Python tracker

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Changes by Antoine Pitrou : -- nosy: +orsenthil versions: +Python 3.3 -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

Changes by Ned Deily : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue13128] httplib debuglevel on CONNECT doesn't print response headers

New submission from Matt Spear : httplib with a debuglevel prints out the response headers, but does not do so with CONNECT requests (when set_tunnel is used). Attached is a small patch to print the reply when the CONNECT request returns something other than 200 OK. I'm not sure if it is wor