Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d38e821c1b80 by Hynek Schlawack in branch 'default':
#13152: Allow to specify a custom tabsize for expanding tabs in textwrap
http://hg.python.org/cpython/rev/d38e821c1b80
--
nosy: +python-dev
Hynek Schlawack h...@ox.cx added the comment:
I've added it myself and committed your code – thank you for your contribution
John!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Hynek Schlawack h...@ox.cx added the comment:
The code LGTM, the documentation lacks `versionchanged` tag though. Would you
mind adding it?
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13152
John Feuerstein j...@feurix.com added the comment:
textwrap_tabsize_v2.diff:
* Moved the tabsize parameter to the end of the parameter list
* Added documentation update
* Made the test case more obvious
--
Added file: http://bugs.python.org/file23624/textwrap_tabsize_v2.diff
Georg Brandl ge...@python.org added the comment:
Two comments:
* The new parameter to __init__ should be added at the end of the parameter
list.
* A documentation update would be nice.
--
___
Python tracker rep...@bugs.python.org
Raymond Hettinger raymond.hettin...@gmail.com added the comment:
+1
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13152
___
Terry J. Reedy tjre...@udel.edu added the comment:
I am a bit surprised this was not part of the original design.
'Tabsize' make 'expand_tabs' redundant and tabsize==0 could be interpreted as
expand_tabs==False. On the other hand, the meaning of 'expand_tabs' could be
expanded to include the
New submission from John Feuerstein j...@feurix.com:
The textwrap module calls .expandtabs() to expand tabs to spaces.
This patch adds support for a custom tabsize, so that .expandtabs(tabsize) is
called instead.
Includes test case.
--
components: Library (Lib)
files:
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
keywords: +needs review
nosy: +georg.brandl
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13152
___
