Changes by Patrick Welche pr...@cam.ac.uk:
--
nosy: +prlw1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
___
Python-bugs-list mailing
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Ok, I find no way to override the linker so that it does not search the current
directory first.
I think it is best, and probably in the spirit of visual studio, to use the
reference part of a project to facilitate linking between
Martin v. Löwis mar...@v.loewis.de added the comment:
I think it is best, and probably in the spirit of visual studio, to
use the reference part of a project to facilitate linking between
dependency projects. it is designed to take the hassle out of
libraries and search paths. I will
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Here is an updated patch, with proper project references added and some slight
cleanup of .props files.
--
Added file: http://bugs.python.org/file25636/pcbuildpatch.patch
___
Python
Jason R. Coombs jar...@jaraco.com added the comment:
After enabling the eol extension and re-checking out my working copy, I've
applied the patch successfully, but after I do so, I get this error when trying
to open the solution in VS2010:
One or more projects in the solution were not loaded
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Ah, good, it looks as though a file is missing from the patch. I'll fix it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
Richard Oudkerk shibt...@gmail.com added the comment:
PCbuild/build.bat and Modules/_decimal/tests/runall.bat still use vcbuild
instead of msbuild.
It also seems that if an external dependency is unavailable then msbuild can
fail to build targets which do not depend on it. For instance if I
Martin v. Löwis mar...@v.loewis.de added the comment:
I propose that we declare this issue closed, and defer any new issues arising
from the switch to VS 2010 in separate issues.
There will surely be many issues over the next weeks and months, and there is
little point in tracking this all on
Martin v. Löwis mar...@v.loewis.de added the comment:
So closing this issue. Kristjan, if you want your patch reviewed further and/or
approved by Brian, please copy it into a new issue.
--
status: open - closed
___
Python tracker
Jason R. Coombs jar...@jaraco.com added the comment:
I agree. There is already an issue regarding the packaging dependencies. It
currently references ctypes, but we can rename it to be more broad.
issue14821
--
Added file: http://bugs.python.org/file25644/smime.p7s
Changes by Martin v. Löwis mar...@v.loewis.de:
Removed file: http://bugs.python.org/file25644/smime.p7s
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
Martin v. Löwis mar...@v.loewis.de added the comment:
No broad issues, please. One tracker item, one issue. If something other than
_ctypes_test fails to build, it may or may not have the same reason, so caution
requires that we assume they are unrelated defects.
--
Martin v. Löwis mar...@v.loewis.de added the comment:
Perhaps you know what revision that patch was against?
I wish people would stop using git-style diffs, then the patch would actually
say. However, it applied cleanly to tip at the time it was submitted, so you
should be able to go by
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Hi, I'll see what went wrong, I admit not trying 64 bit before creating the
patch.
Martin, I´m using MercurialHQ and exporting a patch. It is set up to use GIT
format diffs, which I think is recommended in the Python developer
Martin v. Löwis mar...@v.loewis.de added the comment:
Is this wrong? (I'm still a relative Hg newbie)
It's an ongoing discussion. Some people favor git diffs because
it supports renaming and binaries, I prefer Mercurial diffs, because
it includes the base revision number against the patch was
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
That sounds reasonable. So, can't we come up with a diff that does both? The
base revision sounds like a completely necessary piece of info.
--
___
Python tracker
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
I wish MS could come up with a property editor that could show you _only_ the
properties that are non-default:
1) view all properties
2) view set and inherited non-defaults
3) view properties set here only.
It would make debugging
Martin v. Löwis mar...@v.loewis.de added the comment:
That sounds reasonable. So, can't we come up with a diff that does
both? The base revision sounds like a completely necessary piece of
info.
I believe there is a bug report against Mercurial to include the base
revision even in
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
This is fun.
the reason why linking is failing for some projects in x64 mode is:
the SolutionDir (or maybe current dir) is implicitly part of the library search
path. Therefore, when looking for python33_d.lib, it will find the
Jason R. Coombs jar...@jaraco.com added the comment:
Kristjan,
I'm trying to apply your most recent patch, but many of the hunks fail. I
tried to find it by time, but failed to do so. Perhaps you know what revision
that patch was against? Thanks.
--
nosy: +jason.coombs
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Here is a patch to the .vcproj files and the .props files, based on my earlier
pcbuil10.patch.
Mostly it is about removing redundant settings. It also adds .props files for
the pythoncore solution.
It also updates the readme,
Martin v. Löwis mar...@v.loewis.de added the comment:
LGTM. Brian?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
___
Python-bugs-list
Brian Curtin br...@python.org added the comment:
+1 on the patch. It fixes a bunch of things that I entered unnecessarily (like
explicit .pyd names to fix the warnings), but after staring at the screen for a
long time I couldn't figure out what I was doing wrong to need them for some
reason.
Brian Curtin br...@python.org added the comment:
Hm, actually, doing a 64-bit debug build fails with that patch. ctypes,
_testbuffer, and xxlimited, the projects I originally had trouble with in the
settings, don't link properly.
--
___
Python
Brian Curtin br...@python.org added the comment:
Correction, both 64-bit debug and release fail.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 38d7d944370e by Brian Curtin in branch 'default':
Fix #13210. Port the Windows build from VS2008 to VS2010.
http://hg.python.org/cpython/rev/38d7d944370e
--
nosy: +python-dev
Brian Curtin br...@python.org added the comment:
What I just pushed has functioning debug and release builds for both 32 and 64
bit, and the tests introduce no new failures.
As noted on python-dev, we may not have build slaves setup for this change yet,
so the Windows builds may appear
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
All the old .vcproj files are still there. Probably not useful since the .sln
file has been upgraded to VisualStudio 2010.
--
___
Python tracker rep...@bugs.python.org
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 924c178c0d1d by Brian Curtin in branch 'default':
Move out VS9 project files to PC\VS9.0 folder. Fixes #13210
http://hg.python.org/cpython/rev/924c178c0d1d
--
___
Python
Brian Curtin br...@python.org added the comment:
Thanks for noticing. I moved them out to PC\VS9.0 rather than outright deleting.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
Martin v. Löwis mar...@v.loewis.de added the comment:
I'd say go ahead and apply it. We can deal with any aftermath later (which, by
my VS 2008 experience, will well take several years - we still haven't fully
recovered from the switch to VS 2008).
--
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
I concur with Martin. It is much easier to tweak .vcproj and .props files and
such after it has been committed, with lesser diffs to worry about.
(A more cautious version of me would have seen this go into a PCBuild10 folder
Brian Curtin br...@python.org added the comment:
The tip of the vs2010 branch now works just as well as default does. There are
no outstanding test failures that aren't seen on default -- test_email still
fails for some line ending stuff, but that's not relevant here.
Attached is a patch
Brian Curtin br...@python.org added the comment:
Attached is full_vs2010_port.diff. It's 13000 lines, mostly taken up by the
conversion of project, filter, and solution files - tons of XML.
--
Added file: http://bugs.python.org/file25504/full_vs2010_port.diff
Éric Araujo mer...@netwok.org added the comment:
Strange that you had to edit packaging.compiler.msvc9compiler but not the same
module in distutils.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Posted some comments.
Also, I see you didn't remove the old SxS functionality, no longer used by
VS2010 (see my sxs.patch)
--
___
Python tracker rep...@bugs.python.org
Brian Curtin br...@python.org added the comment:
As of a40f47cc7691, Richard's idea is now the implementation, which seems to
work well and has simplified the changes quite well. Attached is
code_changes.diff which shows all of the necessary code changes as of now.
The test_import failure you
Richard Oudkerk shibt...@gmail.com added the comment:
The problems with error numbers seem to be caused by the addition of a new
section in errno.h:
/* POSIX SUPPLEMENT */
#define EADDRINUSE 100
#define EADDRNOTAVAIL 101
...
#define ETXTBSY 139
#define EWOULDBLOCK 140
Of
Richard Oudkerk shibt...@gmail.com added the comment:
According to http://msdn.microsoft.com/en-us/library/5814770t.aspx the
supported errno values in VS2010 are
E2BIG EACCES EAGAIN EBADF ECHILD EDEADLOCK EDOM EEXIST EILSEQ
EINVAL EMFILE ENOENT ENOEXEC ENOMEM ENOSPC ERANGE EXDEV
Changes by Mark Dickinson dicki...@gmail.com:
--
nosy: +mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
___
Richard Oudkerk shibt...@gmail.com added the comment:
the errno codes (EAGAIN etc) are provided only as a compatibility for
posix apps that test errno. On windows, we use the WSA return values
from the api functions and WsaGetLastError().
...
So, the proposed patch is not a change, it is
Brian Curtin br...@python.org added the comment:
I recently added what you just mentioned in the vs2010port branch for WSA and
non-WSA to work together. I still need to figure out some distutils/packaging
failures, but the port is nearly ready*.
* I've only focused on 32-bit debug builds, but
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Except that Microsoft's C library also uses some of the non-WSA
versions. For instance read() (or _read()) is documented to set
errno to EBADF or EINVAL on error. So EBADF and EINVAL are just as
native as WSAEBADF and
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Brian, I posted a suggested port five weeks ago. What kind of problems are you
having? It's really a very straightforward thing.
--
___
Python tracker rep...@bugs.python.org
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Also, I'm not sure distutils and all that is really necessary. As I understood
it, the goal is to make it so that the casual hacker can compile and run python
using visual studio 2010. 3.3 continues to be officially distributed
Brian Curtin br...@python.org added the comment:
No, this is the real thing. Python 3.3 distributed on VS2010.
In order to ship a fully built Python 3.3 MSI for users, I've found it's not
just as easy as updating errno. I'll strip out all of the project file changes
and whatnot and post a
Brian Curtin br...@python.org added the comment:
Also, I personally don't care about distutils, but I need all of the tests to
pass before I can consider merging this. Distutils and packaging need a few
changes to be able to compile extensions and create setups and whatever with
VS2010.
Éric Araujo mer...@netwok.org added the comment:
Could you attach a file with the distutils/packaging test output? I don’t
really know the packaging.compiler module, but I may be able to make sense of
the error messages and work with you to fix them.
--
Richard Oudkerk shibt...@gmail.com added the comment:
This doesn't change that, and as far as I know, this has worked and
continues to work. errno is supported.
Using your patch, does the following throw an AssertionError?
import os, errno
try:
... os.read(-1, 10)
... except OSError as
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Using your patch, does the following throw an AssertionError?
Yes, it looks as though it will. It seems I was too agressive, since
errnomodule has different entries for EBADF and WSAEBADF.
This is the kind of feedback I'd like
Brian Curtin br...@python.org added the comment:
Yes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
___
Python-bugs-list mailing list
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Super, I must have missed that memo. At PyCon there wasn't much enthusiasm for
it, and this was considered a toy project :)
You may be interested in my patch to see what I did with the project files,
then. Otherwise, I'll be
Martin v. Löwis mar...@v.loewis.de added the comment:
For instance, the sxs patch and the errnomodule patch could go in now
without disturbing anything whatsoever.
I'm not convinced that the errno change is actually correct.
--
___
Python tracker
Martin v. Löwis mar...@v.loewis.de added the comment:
Brian, do I understand you correctly that 2010 is to the official compiler
for 3.3?
Unless we switch to VS 2012, yes.
--
___
Python tracker rep...@bugs.python.org
Brian Curtin br...@python.org added the comment:
I don't have a link handy, but from what I've read we could go from VS2010 to
VS2012 with relative ease since it's supposed to be able to work with 2010
solutions/project files. I haven't tried this with the beta, but I'll take a
look.
Brian Curtin br...@python.org added the comment:
VS11 opened the VS2010 project fine without doing conversion. Note that this
just uses VS11 to work with the project in VS2010 mode with the 2010 compiler.
Doing the conversion to VS11's compiler is another thing to consider, although
probably
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: -haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
___
Python-bugs-list
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
MVL wrote:
I'm not convinced that the errno change is actually correct.
You are right, as SBT pointed out. There are cases where we have had
errno.EFOO and errno.WSAEFOO point to different values, because one was used by
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
[the Soney PS3 sdk also has weird error codes for its otherwise posix
compatible api. I did write a translation layer to convert those codes into
posix codes where appropriate. I could show you what I did, but I'd proably
set
Martin v. Löwis mar...@v.loewis.de added the comment:
The errnomodule patch shouldn't be checked in as is. Instead, an elaborate
comment needs to be added fully explaining the situation with the errno codes,
and giving criteria under which cases it is necessary.
On the face value, it's
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Why should python compiled with VS2010 have different error codes than one
compiled with the older compilers? We could revisit this in a new python
version, but for now, we should maintain compatibility across compilers.
the
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Adding a patch to disable Side by Side assemblies in VS2010 (MS saw the light)
--
keywords: +patch
Added file: http://bugs.python.org/file25003/sxs.patch
___
Python tracker
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Here is a comprehensive patch to errnomodule.c, as used in production at CCP
--
Added file: http://bugs.python.org/file25004/errnomodule.diff
___
Python tracker rep...@bugs.python.org
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Adding a patch containing a proposed PCBuild10 folder.
This consists of:
1) automatically updated .vcxproj and .sol files, provessed by 3) below
2) manually edited and new .props files to edit TargetName and Extension
attributes
3)
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Super Brian, let me know if I can help.
I already did the necessary changes locally.
Martin, what I mean by forward compatibility is simply that the source code
compiles and works with more recent versions of the compiler. The
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
I'd like to subscribe to this newsletter.
IMHO, it is important that people are able to compile python with VS2010 with
minimum fuss. Not everyone has access to older compilers and forward
compatibility shouldn't be that hard.
Martin v. Löwis mar...@v.loewis.de added the comment:
IMHO, it is important that people are able to compile python with
VS2010 with minimum fuss. Not everyone has access to older compilers
and forward compatibility shouldn't be that hard.
Not sure what you mean by forward compatibility. You
Brian Curtin br...@python.org added the comment:
Nothing's keeping it from moving forward at this point. Progress stagnated the
last few months because I was busy doing organizational and PR work for PyCon.
Now that the conference has passed, this and installer changes are on the top
of my
Changes by Jack Jansen jackjan...@users.sourceforge.net:
--
nosy: +jackjansen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
___
Brian Curtin br...@python.org added the comment:
Again, rather than work off of the default branch and duplicate effort, can you
work off of the vs2010 branch on http://hg.python.org/sandbox/vs2010port/?
--
___
Python tracker rep...@bugs.python.org
Sébastien Sablé sa...@users.sourceforge.net added the comment:
I have started working on python default branch.
My patch queue is available here:
https://bitbucket.org/sablefr/py3kvs2010/
The result is the following so far:
323 tests OK.
8 tests failed:
test_distutils test_fileio
Sébastien Sablé sa...@users.sourceforge.net added the comment:
OK Brian, I checked your clone and I will keep an eye on it.
I have done almost the same thing for the moment. My patch queue includes some
additional corrections for a few more bugs that prevented me from completely
running the
Brian Curtin br...@python.org added the comment:
If you want to clone from that repo, use the vs2010 branch.
hg clone http://hg.python.org/sandbox/vs2010port/
hg up vs2010
From there, you can post patches here that I can integrate for you.
--
assignee: - brian.curtin
Éric Araujo mer...@netwok.org added the comment:
A tip to make Mercurial download only a subset of all the changesets in the
repo:
hg clone URI -r branch
or
hg clone URI#branch
(The difference is that in the second form, URI#branch will be recorded in the
.hg/hgrc file and subsequent
Sébastien Sablé sa...@users.sourceforge.net added the comment:
I don't have commit access on hg.python.org, so I also created a clone on
bitbucket at:
https://bitbucket.org/sablefr/py27vs2010/overview
I work with a patch queue for the moment since everything is not completely
settled yet.
Brian Curtin br...@python.org added the comment:
Just to be sure in case you didn't know, but patches against 2.7 for this issue
won't be accepted.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
Sébastien Sablé sa...@users.sourceforge.net added the comment:
Yes I know, but this is my primary target as this is the version that I use in
my product for the moment.
I will test python trunk soon now that Python 2.7 with VS2010 is in a rather
good shape.
--
Éric Araujo mer...@netwok.org added the comment:
Just to avoid misunderstandings: The Subversion concept of trunk (or rather
py3k trunk) maps to the Mercurial branch named default, which is what you get
when you clone hg.python.org/cpython. This is 3.3.
--
Brian Curtin br...@python.org added the comment:
Before we both go down the same paths and duplicate effort,
http://hg.python.org/sandbox/vs2010port/ has already completed the transition
in terms of running the conversion, saving off the VS9 files, making some
minimal code changes (errno
Brian Curtin br...@python.org added the comment:
I mentioned this on another issue, but I created a clone at
http://hg.python.org/sandbox/vs2010port/. I've already gone through the port in
the past but wasn't able to release the code at the time. As I work through it,
I'll occasionally
Tim Golden m...@timgolden.me.uk added the comment:
Thanks. I was going to ask about this to see if anyone had already done
the legwork.
--
nosy: +tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
Sébastien Sablé sa...@users.sourceforge.net added the comment:
Martin, what I want to achieve is to ensure that someone can download Python
sources and compile them without any modification using a standard install of
Windows + Visual Studio 2010 SP1.
I don't really care what is the default
Martin v. Löwis mar...@v.loewis.de added the comment:
Which part of the changes do you consider unnecessary?
All the parts dealing with packaging, in particular Tools/msi.
I understand there is a feature freeze on this branch (event though
the changes in this case are well localized and not
Sébastien Sablé sa...@users.sourceforge.net added the comment:
Packaging makes it easier to distribute Python among my colleagues and
customers, so I think it is a nice addition.
OK for the hg clone, I will set up that (I actually already use mercurial
internally to handle those
New submission from Sébastien Sablé sa...@users.sourceforge.net:
Python for Windows is currently compiled with Visual Studio 2008.
It is not possible to use Visual Studio 2010.
It would be great to be able to compile Python with Visual Studio 2010:
* some people may only have access to this
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: +brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
___
Brian Curtin br...@python.org added the comment:
We can make Python compile with Visual Studio 2010, but it will not be the
platform Python is released on, it would be optional while 2008 stays the
release target, at least through Python 3.3. In Python 3.4, we may re-evaluate
this, and it's
Sébastien Sablé sa...@users.sourceforge.net added the comment:
Here is a quick and dirty draft of the modifications I had to do in order to
get Python 2.7.2 to compile with VS2010 on the wiki:
http://wiki.python.org/moin/VS2010
I will improve/complete it as I progress.
I will also do a 64
Changes by Santoso Wijaya santoso.wij...@gmail.com:
--
nosy: +santa4nt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13210
___
___
Éric Araujo mer...@netwok.org added the comment:
The wiki page contains change to distutils, which I believe would not be
allowed by the feature freeze. New features (such as support for a new
compiler) need to target packaging.
--
___
Python
Martin v. Löwis mar...@v.loewis.de added the comment:
I think this issue urgently needs a scope defined. What *exactly* is it that
you want to achieve? If it's merely being able to compile Python with VS 2010,
many of the proposed changes are unnecessary.
If you propose that the patch should
93 matches
Mail list logo
