[issue13464] HTTPResponse is missing an implementation of readinto

2020-10-23 Thread Felipe Rodrigues
Change by Felipe Rodrigues : -- nosy: +fbidu nosy_count: 5.0 -> 6.0 pull_requests: +21847 pull_request: https://github.com/python/cpython/pull/22737 ___ Python tracker ___

[issue13464] HTTPResponse is missing an implementation of readinto

2012-01-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4b21f651 by Antoine Pitrou in branch 'default': Issue #13713: fix a regression in HTTP chunked reading after 806cfe39f729 http://hg.python.org/cpython/rev/4b21f651 -- ___ Python tracker

[issue13464] HTTPResponse is missing an implementation of readinto

2011-12-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, thank you. I've now committed the patch in the default branch. Congratulations! (since the documentation doesn't claim that HTTPResponse implements RawIOBase, I tend to consider this a feature request rather than a bugfix, hence no 3.2 commit) -

[issue13464] HTTPResponse is missing an implementation of readinto

2011-12-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 806cfe39f729 by Antoine Pitrou in branch 'default': Issue #13464: Add a readinto() method to http.client.HTTPResponse. http://hg.python.org/cpython/rev/806cfe39f729 -- nosy: +python-dev ___ Python tracke

[issue13464] HTTPResponse is missing an implementation of readinto

2011-12-04 Thread Jon Kuhn
Jon Kuhn added the comment: Thanks for the comments. Attached is an updated patch. In the RawIOBase docs it says "If the object is in non-blocking mode and no bytes are available, None is returned." So I wasn't sure if that meant any time no bytes were available or just when no bytes are av

[issue13464] HTTPResponse is missing an implementation of readinto

2011-12-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: Hello Jon, and thanks for the patch. I have a couple of comments: - readinto() shouldn't return None but 0 when there is nothing to read (this corresponds to read() returning b"") - I see _read_chunked() is only ever called with amt=None, so perhaps it can be

[issue13464] HTTPResponse is missing an implementation of readinto

2011-12-03 Thread Jon Kuhn
Jon Kuhn added the comment: This is my first contribution to a real open source project. Attached is my patch. Suggestions for improvements are welcome. -- keywords: +patch nosy: +Jon.Kuhn Added file: http://bugs.python.org/file23847/issue13464.patch _

[issue13464] HTTPResponse is missing an implementation of readinto

2011-11-23 Thread R. David Murray
New submission from R. David Murray : HTTPResponse subclasses RawIOBase, but does not provide an implementation of readinto, only read. This means that it is not conforming to the IO spec, and so it cannot be wrapped in a BufferedIOBase when using the C version of io. -- components: L