[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Change by Takuya N : -- nosy: +tnir nosy_count: 15.0 -> 16.0 pull_requests: +24151 pull_request: https://github.com/python/cpython/pull/25420 ___ Python tracker ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Kubilay Kocak added the comment: @Gregory I'm the worker owner and can coordinate buildbot worker changes with Zach or Victor FreeBSD has: editline (in FreeBSD base, installed in /usr/ ) libedit in ports/packages (installs in /usr/local) readline in ports/packages (installs in /usr/local)

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Gregory P. Smith added the comment: That seems like a good idea to prevent regressions if anyone knows how to do that. For python.org/dev/'s buildbot fleet, the configuration of what configure and make flags happens via https://github.com/python/buildmaster-config/tree/master/master/custom

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Kubilay Kocak added the comment: Would we like the freebsd worker CI configurations to be modified to use ports/package versions of libedit (or readline, or whatever) to ensure converage? Right now the defaults are used (whatever edit library that entails) --

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Gregory P. Smith added the comment: I'm closing this as I believe everything we need done is done at this point. Open new issues if there are remaining libedit vs libreadline things to take care of. Thanks everyone! -- resolution: -> fixed stage: patch review -> commit review

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Gregory P. Smith added the comment: New changeset e1f77695132e814728cda982f11342a2e3c7272c by Roland Hieber in branch 'master': bpo-13501: allow choosing between readline and libedit (GH-24189) https://github.com/python/cpython/commit/e1f77695132e814728cda982f11342a2e3c7272c --

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Roland Hieber added the comment: Okay, I've had a look at this, and it seems that all the heavy lifting is already included in 68669ef7883 (via #38634, PR 16986). The selection of libedit vs. readline still needs to be ported. I've prepared (and tested) PR 24189 for the rebase of this patch

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Change by Roland Hieber : -- pull_requests: +23016 pull_request: https://github.com/python/cpython/pull/24189 ___ Python tracker ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Roland Hieber added the comment: (That was meant to be 68669ef7883 for the autolinking feature) -- ___ Python tracker ___ ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Roland Hieber added the comment: What's the status of this patch? Is it still needed after 68669ef7883e, which went into v3.8.1? -- nosy: +rhi ___ Python tracker ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Gregory P. Smith added the comment: at a glance, it looks like the PR needs updating. -- ___ Python tracker ___ ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Enji Cooper added the comment: Is there something I can do to help move this change along? 8 years is a long time for an issue to be open :(. -- ___ Python tracker ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Change by Gregory P. Smith : -- versions: +Python 3.10 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Change by Gregory P. Smith : -- versions: +Python 3.9 -Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Change by serge-sans-paille : -- pull_requests: +16513 pull_request: https://github.com/python/cpython/pull/16986 ___ Python tracker ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

egaudry added the comment: Hi, I think that there are some issues in the last patch (0001-Build-or-disable-readline-module-with-Editline.patch) made available. For instance, the using_libedit_emulation variable should be protected by DETECT_EDITLINE ifdef (and not SUPPORT_EDITLINE). And the

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Gregory P. Smith added the comment: In PR it you refer to -ledit and to editline. libedit and libeditline appear to be two different libraries. I was under the impression that libedit is the desirable one (it's what *BSD uses - coming originally from NetBSD if I understand correctly -

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Robert Marshall added the comment: The pull request is now ready for a review. Apologies for the delay - took me a bit longer to circle back on this than I would have liked. -- ___ Python tracker

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Robert Marshall added the comment: I have rebased this to recent master hash 53b9e1a1c1 and submitted a pull request. It built in my CI environment, so seems to be OK as far as compiling. I'll run the test suite against it later this evening when I have time to stand up a quick build

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Change by Enji Cooper : -- versions: +Python 2.7, Python 3.4, Python 3.5, Python 3.7, Python 3.8 ___ Python tracker ___ ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Enji Cooper added the comment: I'll try to rebase Martin's changes, as they don't apply to the master branch on GitHub today. -- ___ Python tracker ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Mark Harfouche added the comment: Right, but when do you actually use the bare python interpreter? I'm always on ipython or something that uses that as the backend. On Sun, Oct 28, 2018 at 4:12 PM Romain Geissler wrote: > > Romain Geissler added the comment: > > Yes in my case the build

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Romain Geissler added the comment: Yes in my case the build works, but then I have a resulting python interpreter with limited readline functionality. That's why I have some interest in having this patch rebased and included into trunk. -- ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Mark Harfouche added the comment: My workaround has been to use neither readline nor libedit. On Sun, Oct 28, 2018 at 2:40 PM Romain Geissler wrote: > > Romain Geissler added the comment: > > Hi, > > Yes this bug report is still valid. I just tried compiling Python 3.7.1 on > linux with

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Romain Geissler added the comment: Hi, Yes this bug report is still valid. I just tried compiling Python 3.7.1 on linux with libedit installed (https://thrysoee.dk/editline/) but not libreadline, and indeed the configure script fails to detect I have it installed and falls back on the

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Mark Harfouche added the comment: Is there still interest in this? -- nosy: +Mark Harfouche ___ Python tracker ___ ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Martin Panter added the comment: Patch v4 resolves conflicts against the current code. I also used AC_CHECK_DECL invocations instead of AC_COMPILE_IFELSE in the configure script. FTR I think my problems with the prompt and the terminal settings are caused by a line of code that is commented

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Martin Panter added the comment: Patch v3 is an update taking into account Ned’s comments, and my own now deeper understanding: * Reworked the --with-readline handling. Suggested options are --with-readline=editline, and --without-readline. The current behaviour (use -lreadline if possible)

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Martin Panter added the comment: Quoting Ned: “The current behavior is: enable building readline with GNU readline if found on the search paths, . . . and, if not found and on OS X, use editline if found on the search paths. Some build scripts depend on that behavior.” Can you point out any

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Martin Panter added the comment: Thanks for the review Ned. I haven’t looked too closely but your comments sound reasonable in general. I don’t have a personal need to update this patch (Editline doesn’t work well for me on Linux), but I can try to update it if there is demand for this.

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Ned Deily added the comment: Martin, thanks for updating the patch. I've left some review comments on Rietveld. After reviewing it, I think Garrett's original specification is correct: there is a need for four options to preserve current expected behavior although the default is slightly

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Ned Deily added the comment: That said, it *might* be OK to change the default behavior to just remove the "and on OS X" condition: enable building readline with GNU readline if found on the search paths, possibly modified by CPPFLAGS and LDFLAGS, and, if not found, use editline if found on

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Changes by Ismail Donmez ism...@donmez.ws: -- nosy: +cartman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13501 ___ ___ Python-bugs-list mailing

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Ed Maste added the comment: I believe the 0-based vs 1-based history is only one of a few different inconsistencies between libedit and readline. Workarounds will be necessary until a fixed libedit is deployed on all operating systems / distros of interest, but yes I agree that eventually

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Ed Maste added the comment: Actually, in msg245395 I should claim the issue is with libedit / GNU readline compatibility and/or the workarounds in Python's readline module, not that it's specifically Issue24388. -- ___ Python tracker

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Changes by koobs koobs.free...@gmail.com: -- nosy: +koobs ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13501 ___ ___ Python-bugs-list mailing

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Ed Maste added the comment: It looks like rust developers hit the issue in Issue24388 with lldb on Ubuntu 15.04 as well: https://github.com/rust-lang/rust/issues/26297 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13501

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Martin Panter added the comment: Maybe I am missing something, but is it possible to use a newer version of Editline (libedit) that fixes the compatibility bug, as mentioned in Issue 18458? -- ___ Python tracker rep...@bugs.python.org

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Ned Deily added the comment: See also suggested patch in Issue24388. -- nosy: +emaste stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13501 ___

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Ned Deily added the comment: The suggested change to generalize support for libedit to other platforms is a new feature so, by default, it would first appear in a new feature release, e.g. 3.6. There would probably have to be an exception granted to add it to 2.7.x or other 3.x releases,

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Ed Maste added the comment: Note that the patch in Issue24388 is more a proof of concept. I'm not sure it's the right fix. LLDB is a bit of a special case: LLDB links against libedit, but the Python libedit module is built as if readline is in use. It turns out this magically works out,

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Ed Maste added the comment: This issue causes the LLDB debugger to crash on FreeBSD (it uses Python as its embedded script interpreter). What needs to be done to make some progress on this issue? -- ___ Python tracker rep...@bugs.python.org

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Martin Panter added the comment: Garrett Cooper: If you are still around, you might want to review the following three changes in this new patch. I suspect they were mistakes in your version, but I cannot be 100 percent sure. * Restoring length - 1 subtraction in call_readline() at line 1239

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Éric Araujo mer...@netwok.org added the comment: ISTM --with-readline=yes should just be --with-readline, and the =no forms should just be --without-readline. That would be more in line with other options and less confusing (--without-readline=no ?!). There is no trunk anymore now that we’ve

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Éric Araujo mer...@netwok.org added the comment: And if this is really two different requests (port readline module to FreeBSD i.e. change if __APPLE__ to if HAVE_EDITLINE and give more control about readline vs. editline in the configure script), then two reports should be opened.

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Ned Deily n...@acm.org added the comment: Without having yet done a detailed review of the patch and the configure options, I don't see a need to open a second issue. The scope of this one is fine: generalizing the support of libedit to other platforms. --

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

New submission from Garrett Cooper yaneg...@gmail.com: The attached patch enables libedit support in a generic way via configure.in, so I can pass in --with-readline=editline, --with-readline=readline, --with-readline=yes, or --with[out]-readline[=no] and it will do one of the following: 1.

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Changes by Antoine Pitrou pit...@free.fr: -- components: +Build nosy: +ned.deily, ronaldoussoren stage: - patch review versions: +Python 3.3 -Python 2.7, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13501

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Changes by Ned Deily n...@acm.org: -- assignee: - ned.deily ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13501 ___ ___ Python-bugs-list mailing

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

Changes by STINNER Victor victor.stin...@haypocalc.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13501 ___ ___