Brett Cannon br...@python.org added the comment:
Patch looks good to me.
--
assignee: - meador.inge
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13591
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d2504d30f259 by Meador Inge in branch '3.2':
Issue #13591: import_module potentially imports a module twice.
http://hg.python.org/cpython/rev/d2504d30f259
New changeset e8fb61a0a2d7 by Meador Inge in branch
Meador Inge mead...@gmail.com added the comment:
Thanks for the review Brett. Fix committed.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 541f215a31f7 by Meador Inge in branch '3.2':
Issue #13591: Moving the NEWS line to the right release.
http://hg.python.org/cpython/rev/541f215a31f7
New changeset 92e94fd303d4 by Meador Inge in branch 'default':
Meador Inge mead...@gmail.com added the comment:
I can reproduce this on tip. What happens is that
'importlib.import_module(my_lib.bar)' is effectively computed as:
import my_lib
import bar
by '_bootstrap._gcd_import'. When '_gcd_import' goes to do the import
of 'bar' it does *not*
Changes by Antoine Pitrou pit...@free.fr:
--
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13591
___
___
Python-bugs-list
Ryan Twitchell metatheo...@gmail.com added the comment:
Confirmed that this patch fixes the behavior shown in my original example, with
3.2.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13591
Meador Inge mead...@gmail.com added the comment:
Updated patch with tests.
--
Added file: http://bugs.python.org/file23951/issue13591-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13591
New submission from Ryan Twitchell metatheo...@gmail.com:
Use of importlib's import_module function with modules belonging to a library
can cause some modules to be imported twice, if such a module is referenced
from sibling modules, and from __init__ in the package. I suspect this is a
bug, or
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +brett.cannon, ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13591
___
___
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13591
___
___
Python-bugs-list
Nick Coghlan ncogh...@gmail.com added the comment:
At first glance, I thought this might be just the circular import problem
(#992389) appearing in a different guise. However, if that was the case,
switching to an import statement or __import__ shouldn't have made any
difference.
What do you
12 matches
Mail list logo
