R. David Murray added the comment:
Ah, yes, I see. Sorry for the confusion, I misread that part of the discussion
and did not look at that part of the docs.
(I find that note confusing...it seems to imply that a2b only accepts ascii.
But that's a different issue and I don't feel strongly
R. David Murray added the comment:
I think this doc change was incorrect. The current document is supposed to
provide the correct historical information. So changed in 3.3: accept ASCII
input (and just ignore the fact that 3.1 also accepted ascii, since we pretty
much prefer to ignore the
Martin Panter added the comment:
If I understand what you are saying, you don’t mind not mentioning 3.1
behaviour, but want to mention 3.2 behaviour. Perhaps the existing “Note” box
at the top of the page is good enough for you, as pointed out in
http://bugs.python.org/issue13637#msg235931.
Roundup Robot added the comment:
New changeset 8d32453dd0f7 by Berker Peksag in branch '3.4':
Issue #13637: Remove outdated versionchanged directives.
https://hg.python.org/cpython/rev/8d32453dd0f7
New changeset d3ca674cf716 by Berker Peksag in branch 'default':
Issue #13637: Remove outdated
Berker Peksag added the comment:
Thank you to both Vajrasky and Martin.
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13637
Roundup Robot added the comment:
New changeset ad4a8176a71a by Berker Peksag in branch '3.4':
Issue #13637: Improve exception message of a2b_* functions.
https://hg.python.org/cpython/rev/ad4a8176a71a
New changeset 55f5e960cc40 by Berker Peksag in branch 'default':
Issue #13637: Improve
Berker Peksag added the comment:
The binascii documentation already says
``a2b_*`` functions accept Unicode strings containing only ASCII characters.
[...]
.. versionchanged:: 3.3
ASCII-only unicode strings are now accepted by the ``a2b_*`` functions.
I think we can just remove
Martin Panter added the comment:
That’s another option. Someone might wonder why a2b_hex() and a2b_qp() actually
accept text strings in Python 3.1 when the documentation says you need 3.3, but
I guess that’s not such a big deal. Posting patch v3 which removes the 3.2
notices.
--
Martin Panter added the comment:
The error fix patch looks good.
I updated the doc patch as fix_doc_binascii_unhexlify.v2.patch, which also
clarifies a2b_qp(), and restores the description of Python 3.2 not allowing
text strings.
--
assignee: - docs@python
components: +Documentation
Martin Panter added the comment:
The a2b_qp() function also documents a byte string restriction for 3.2, and now
3.3 also seems to support ASCII-compatible text strings. Maybe the
documentation should reflect this also?
--
nosy: +vadmium
___
Python
Vajrasky Kok added the comment:
Here is another patch to better the error message. Right now, the error message
when wrong input sent to unhexlify is a little bit funny.
import binascii
binascii.unhexlify(3)
Traceback (most recent call last):
File stdin, line 1, in module
TypeError:
Vajrasky Kok added the comment:
Antoine, I think you forgot to update the doc.
http://docs.python.org/3.4/library/binascii.html#binascii.unhexlify
Changed in version 3.2: Accept only bytestring or bytearray objects as input.
Attached the patch to update the doc to reflect the changes in this
Luke-Jr luke...@users.sourceforge.net added the comment:
Has this been fixed in 3.2 yet? Somehow it seems to have been reclassified as
an enhancement when it's really a regression. str worked fine in these
functions in 3.1.
--
nosy: +luke-jr
___
Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com added the comment:
I confirm that it works in Python 3.1 and doesn't work in Python 3.2.
--
nosy: +Arfrever
resolution: fixed -
stage: committed/rejected -
status: closed - open
type: enhancement - behavior
R. David Murray rdmur...@bitdance.com added the comment:
Discussion resolved in favor of patch.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13637
___
R. David Murray rdmur...@bitdance.com added the comment:
I disagree with this feature. Reopening pending discussion on python-dev.
--
nosy: +r.david.murray
status: closed - open
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
Here is a patch.
--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file24060/binasciistr.patch
___
Python tracker rep...@bugs.python.org
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset eb8d62706d5f by Antoine Pitrou in branch 'default':
Issue #13637: a2b functions in the binascii module now accept ASCII-only
unicode strings.
http://hg.python.org/cpython/rev/eb8d62706d5f
--
nosy:
Antoine Pitrou pit...@free.fr added the comment:
Committed now.
--
resolution: - fixed
stage: patch review - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13637
___
Changes by Antoine Pitrou pit...@free.fr:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13637
___
___
Python-bugs-list
New submission from Antoine Pitrou pit...@free.fr:
a2b_hex and friends accept only byte strings:
binascii.a2b_hex(b'00')
b'\x00'
binascii.a2b_hex('00')
Traceback (most recent call last):
File stdin, line 1, in module
TypeError: 'str' does not support the buffer interface
But they could
21 matches
Mail list logo
