Éric Araujo added the comment:
Thanks for the report and patches!
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13934
___
Roundup Robot added the comment:
New changeset b8b26feb3e1a by R David Murray in branch '3.2':
#13934: document sqlite version strings, use correct one in test.
http://hg.python.org/cpython/rev/b8b26feb3e1a
New changeset cdf9142a0c84 by R David Murray in branch '3.3':
merge #13934: document
R. David Murray added the comment:
These patches are small enough a contributor agreement is not required, but it
would still be great if you would submit one, poq.
--
nosy: +r.david.murray
stage: patch review - committed/rejected
status: open - closed
Petri Lehtinen pe...@digip.org added the comment:
poq: I see you have submitted a few other patches to the tracker, too. For us
to be able to use your patches, you should sign the PSF Contributor Agreement
as described here: http://www.python.org/psf/contrib/.
--
Petri Lehtinen pe...@digip.org added the comment:
Both patches LGTM.
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13934
___
poq p...@gmx.com added the comment:
Now with proper skipping.
--
Added file: http://bugs.python.org/file25622/sqlite3-test-hooks.v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13934
poq p...@gmx.com added the comment:
Sure, why not. Here you go.
--
Added file: http://bugs.python.org/file25616/sqlite3-version-doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13934
Éric Araujo mer...@netwok.org added the comment:
Thanks! The code patch should use unittest.skip instead of return (even if the
rest of the file uses return, we can improve that one step at a time).
--
nosy: +eric.araujo
___
Python tracker
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13934
___
___
Sandro Tosi sandro.t...@gmail.com added the comment:
poq, would you like to also prepare a patch for the documentation with what
Thomas suggested? I'd be happy to review when ready
--
nosy: +sandro.tosi
___
Python tracker rep...@bugs.python.org
Thomas Spura toms...@fedoraproject.org added the comment:
It might be good to add some documentation to the sqlite3 module and describe
that version_info is only the PYSQLITE_VERSION and not the version of the
sqlite library.
--
nosy: +tomspur
___
New submission from poq p...@gmx.com:
The test CheckCollationIsUsed in Lib/sqlite3/test/hooks.py never runs because
it checks the wrong version tuple. Patch attached.
--
components: Tests
files: sqlite3-test-hooks.patch
keywords: patch
messages: 152548
nosy: poq
priority: normal
Changes by Éric Araujo mer...@netwok.org:
--
assignee: - ghaering
keywords: +needs review
nosy: +ghaering
stage: - patch review
versions: +Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13934
13 matches
Mail list logo