[issue14004] Distutils filelist selects too many files on Windows

Roundup Robot added the comment: New changeset edcdef70c44e by Éric Araujo in branch '3.2': Fix long-standing bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/cpython/rev/edcdef70c44e -- ___ Python tracker

[issue14004] Distutils filelist selects too many files on Windows

Roundup Robot added the comment: New changeset 4d6a9f287543 by Éric Araujo in branch 'default': Fix bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/distutils2/rev/4d6a9f287543 -- ___ Python tracker

[issue14004] Distutils filelist selects too many files on Windows

Roundup Robot added the comment: New changeset 73aa4c9305b3 by Éric Araujo in branch '3.2': Fix long-standing bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/cpython/rev/73aa4c9305b3 -- ___ Python tracker

[issue14004] Distutils filelist selects too many files on Windows

Roundup Robot added the comment: New changeset 47788c90f80b by Éric Araujo in branch '2.7': Fix long-standing bugs with MANIFEST.in parsing on Windows (#6884). http://hg.python.org/cpython/rev/47788c90f80b -- nosy: +python-dev ___ Python tracker

[issue14004] Distutils filelist selects too many files on Windows

Éric Araujo added the comment: This regex bug was actually already known. Please follow up on the other report. > As an aside, it seems that the failing test from issue 13193 was > actually correct, and that the library itself was broken. Yes. filelist operates in this way: it builds a list

[issue14004] Distutils filelist selects too many files on Windows

Nadeem Vawda added the comment: > At first glance, Nadeem’s proposed fix is not right: paths in MANIFEST.in use > '/', but then filelist produces paths using os.sep, so that the MANIFEST file > and other operations done by the sdist command use native paths. So even > though the currently su

[issue14004] Distutils filelist selects too many files on Windows

Éric Araujo added the comment: So it looks like that even if the exclusion of .hg removes .hg/last-message.txt, it should not have been added in the first place, as the command was include and not recursive-include. At first glance, Nadeem’s proposed fix is not right: paths in MANIFEST.in use

[issue14004] Distutils filelist selects too many files on Windows

Jason R. Coombs added the comment: It's not that I forgot to set DISTUTILS_DEBUG, I simply did not set it. If the bug were still present, I would have seen a line indicating that .hg/last-message.txt was being copied. For completeness, here's the output with the DEBUG setting: PS C:\User

[issue14004] Distutils filelist selects too many files on Windows

Nadeem Vawda added the comment: > The bug is indeed fixed in the latest 2.7 tip: > > PS C:\Users\jaraco\projects\public\keyring> > C:\Users\jaraco\projects\public\cpython\PCbuild\amd64\python.exe setup.py > sdist 2> NULL | findstr .hg >(produces no output) I suspect you forgot to set

[issue14004] Distutils filelist selects too many files on Windows

Jason R. Coombs added the comment: If always using a posix path separator, I recommend using posixpath.join instead of hard-coding the path separator. -- ___ Python tracker ___

[issue14004] Distutils filelist selects too many files on Windows

Jason R. Coombs added the comment: The bug is indeed fixed in the latest 2.7 tip: PS C:\Users\jaraco\projects\public\keyring> C:\Users\jaraco\projects\public\cpython\PCbuild\amd64\python.exe setup.py sdist 2> NULL | findstr .hg (produces no output) -- ___

[issue14004] Distutils filelist selects too many files on Windows

Nadeem Vawda added the comment: I've been able to reproduce this on current builds of 2.7, 3.2 and 3.3. The problem seems to be that distutils.filelist pathnames using the OS directory separator, but the regexps used for matching paths are written to always assume "/"-based paths. I've been ab

[issue14004] Distutils filelist selects too many files on Windows

Éric Araujo added the comment: This code just got changed (#13193) to use '/' instead of os.path.join, as it is documented that paths in MANIFEST.in must use only '/'. Can you build an up-to-date Python 2.7 from Mercurial and check again? Your report comes timely, as there was some doubt abo

[issue14004] Distutils filelist selects too many files on Windows

Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue14004] Distutils filelist selects too many files on Windows

Changes by Jason R. Coombs : -- components: +Windows ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue14004] Distutils filelist selects too many files on Windows

New submission from Jason R. Coombs : When using a MANIFEST.in with only "include *.txt", on Windows, distutils grabs too many files. I set DISTUTILS_DEBUG=1 and ran ./setup.py sdist on the keyring library and it included this output: include *.txt include_pattern: applying regex r'^[^