Eli Bendersky eli...@gmail.com added the comment:
Fix committed - Windows bots now compile successfully.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14065
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 14abfa27ff19 by Eli Bendersky in branch 'default':
Fixes and enhancements to _elementtree:
http://hg.python.org/cpython/rev/14abfa27ff19
--
___
Python tracker
Changes by Eli Bendersky eli...@gmail.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14065
___
Stefan Krah stefan-use...@bytereef.org added the comment:
Just in case you missed it: The Windows buildbots fail to compile
14abfa27ff19:
http://www.python.org/dev/buildbot/all/builders/x86%20Windows7%203.x
--
nosy: +skrah
___
Python tracker
Eli Bendersky eli...@gmail.com added the comment:
Stefan, thanks. The windows bots were down when I was looking :-/
I'll work on a fix
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14065
Eli Bendersky eli...@gmail.com added the comment:
Attaching a patch that should fix the build - I don't have write access to
commit where I am - will be able to commit it later today.
--
Added file: http://bugs.python.org/file25113/issue14065_buildfix.patch
Eli Bendersky eli...@gmail.com added the comment:
Re-opening, since GC collection of length-2 cycles cause refleaks (Issue
#14464).
For now the test was reverted in changeset c5cf48752d81 - it has to be put back
when this is fixed.
--
resolution: fixed -
stage: committed/rejected -
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 0ca32013d77e by Eli Bendersky in branch 'default':
Issue #14065: Added cyclic GC support to ET.Element
http://hg.python.org/cpython/rev/0ca32013d77e
--
nosy: +python-dev
Changes by Eli Bendersky eli...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14065
___
Eli Bendersky eli...@gmail.com added the comment:
Find attached a patch.
Added cyclic GC support to Element objects. Also added tests that verify that
cycles involving Element objects are being collected.
I'd really appreciate a review on this, since this is the first time I have to
Martin v. Löwis mar...@v.loewis.de added the comment:
As a matter of principle, garbage collection in Python should *always* work,
for all types, except for the one documented exception (cycles involving
__del__). Failure of a type to properly garbage collect should be considered as
serious
Changes by Eli Bendersky eli...@gmail.com:
--
assignee: - eli.bendersky
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14065
___
Eli Bendersky eli...@gmail.com added the comment:
Martin, why do you think it's important for Element to support this? After all,
this is XML, not an arbitrary tree. As such, the children of Element can only
be other elements, and attribute values should be strings. Anything else will
result
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14065
___
___
Python-bugs-list
New submission from Martin v. Löwis mar...@v.loewis.de:
The C implementation of xml.etree.ElementTree.Element needs to support cyclic
GC. The attached script demonstrates the lack to support that: in 3.2, the
script passes; in 3.3 (7697223df6df) it fails with an AssertionError as the
cycle
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14065
___
___
Python-bugs-list mailing list
Changes by Antoine Pitrou pit...@free.fr:
--
components: +Library (Lib)
nosy: +flox
stage: - needs patch
type: - behavior
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14065
17 matches
Mail list logo
