Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 02f13577b6fe by Nick Coghlan in branch 'default':
Close #14136 by cleaning up the PEP 409 command line test (patch by Ethan
Furman)
http://hg.python.org/cpython/rev/02f13577b6fe
--
nosy: +python-dev
Ethan Furman et...@stoneleaf.us added the comment:
Nick Coghlan wrote:
Nick Coghlan ncogh...@gmail.com added the comment:
Hah, I've been dealing with Python's regression test suite for 8+ years and
there are still cases where I don't understand the rationale for testing
things a
Ethan Furman et...@stoneleaf.us added the comment:
Modified test name to test_pep_409_verbiage(); modified test body to use same
pattern as other tests, thus eliminating the dangling test script files after
the test was run.
--
Added file:
Nick Coghlan ncogh...@gmail.com added the comment:
Yup, I plan to get a few things like this incorporated once I have broadband
access at home again. Probably won't be early enough to get things into alpha
2, but they should make it for alpha 3.
--
Ethan Furman et...@stoneleaf.us added the comment:
Changed TestTraceback.test_traceback_verbiage to use test.support and
test.script_helper (much simpler now, thanks Antoine!).
It is still in test_raise, however.
I do not understand why we would put it in test_cmd_line_script -- it seems to
Nick Coghlan ncogh...@gmail.com added the comment:
It's about separating out the testing of the command line executable (i.e.
test_cmd_line and test_cmd_line_script) from that of the interpreter's internal
behaviour.
test_raise is about making sure the raise statement works correctly - the
Ethan Furman et...@stoneleaf.us added the comment:
Is there a better place, then, than test_cmd_line_script?
The entire purpose of PEP 409 is to allow the suppression of non-relevant
information in the exception traceback. As such I would expect every Python
interpreter to adhere to it.
Ethan Furman et...@stoneleaf.us added the comment:
I guess the crux of the issue for me is that I'm trying to test interpreter
output, and the fact that I am using a command-line script to do so is an
implementation detail.
--
___
Python tracker
Nick Coghlan ncogh...@gmail.com added the comment:
test_cmd_line and test_cmd_line_script are both about testing the behaviour of
the interpreter when run from the command line. Since this test *is* a
behavioural test for the interpreter when invoked as an application, it should
be in one of
Ethan Furman et...@stoneleaf.us added the comment:
Moved to test_cmd_line_script.
--
Added file: http://bugs.python.org/file24672/raise_from_none_test_cleanup.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14136
Ethan Furman et...@stoneleaf.us added the comment:
Nick,
Thank you for your thorough answers. I'm not trying to be difficult,
just trying to learn and understand.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14136
Nick Coghlan ncogh...@gmail.com added the comment:
Hah, I've been dealing with Python's regression test suite for 8+ years and
there are still cases where I don't understand the rationale for testing things
a particular way (beyond it must have seemed like a good idea at the time).
It has a
New submission from Nick Coghlan ncogh...@gmail.com:
I stuffed up the review on one of the new tests in the PEP 409 patch - the one
that checks if the exception context is suppressed correctly from the command
line.
That test should be drastically simplified and moved from test_raise to
13 matches
Mail list logo
