Martin Panter added the comment:
In the meantime, Issue 24599 has been opened about URLopener(), which I
understand is related to the Python 2 “urllib” half of this bug. Since this
issue has been closed, perhaps it is best to continue discussion of
issue1424152-py27-urllib.diff there instead.
Senthil Kumaran added the comment:
I have a slight fear that this patch could be considered as a feature addition
in 2.7 urllib.py, I would like to quell that and ensure that behaviour
expectation is consistent when using urllib or urllib2 and latest
urllib/request.py modules.
Also, tests +
Lukas Wunner added the comment:
*ping*
Anybody, please consider applying the patch I've submitted August 8th so that
this issue gets fixed in Python 2.7's urllib.py.
Thanks so much.
--
___
Python tracker rep...@bugs.python.org
Lukas Wunner added the comment:
Unfortunately this bug was only fixed in urllib2.py but never in urllib.py.
This keeps biting people in the butt to this very day. Example:
https://chromiumcodereview.appspot.com/10825107/
The attached patch remedies that and also fixes some more issues:
(1)
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: +Python 3.2 -Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
___
___
Senthil orsent...@gmail.com added the comment:
Agreed to the suggestions made by Greg.
The fix is now backported.
For Py2.6 in the revision 74203.
For Py3k in the revision 74204.
Closing this issue.
--
status: open - closed
___
Python tracker
Gregory P. Smith g...@krypto.org added the comment:
*Rereads latest patch*
I'm happy with this being backported as a bugfix to 3.1 and 2.6 so long
as the set_tunnel method is hidden. Call it _set_tunnel() in the
backport (and don't document its existence).
--
Senthil orsent...@gmail.com added the comment:
Fixed for 3.2 in py3k branch revision 74198. Asked python-dev for
objections on back porting changes 2.6.
Shall back port changes to py2.6 and py3.1
--
___
Python tracker rep...@bugs.python.org
Changes by Senthil orsent...@gmail.com:
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
___
___
Python-bugs-list
R. David Murray rdmur...@bitdance.com added the comment:
Personally I would like to see that happen, but I think you should
probably poll python-dev since it can be argued either way as to whether
it is a bug fix or a new feature. FWIW, from the feeder bug reports it
looks to me like the users
James Broadhead jamesbroadh...@gmail.com added the comment:
+1 to the above.
(imo, this is a bugfix, not a new feature)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
___
Hans Lellelid h...@velum.net added the comment:
Personally, I also think that this is a bugfix, though I realize that in
order to fix the bug an API addition had to be made. So +1 from me on
rolling into 2.6 (though my opinion is simply that of someone who's
eager to see it fixed).
--
R. David Murray rdmur...@bitdance.com added the comment:
Note that this bug is also of concern to Ubuntu. See for example
https://bugs.launchpad.net/python/+bug/94130.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
Senthil orsent...@gmail.com added the comment:
This is actually fixed in Py2.7 and I am trying to get it Py3.2 before
marking this as fixed.
Based on the comments, should this be backported to Py2.6?
--
___
Python tracker rep...@bugs.python.org
Jarek jarek@gmail.com added the comment:
+1 for mercurial inoperability from behind proxy
--
nosy: +jarek.jpa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
___
Benjamin Peterson benja...@python.org added the comment:
Senthil, are you still working on the 3.x version of the patch?
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
Senthil orsent...@gmail.com added the comment:
Senthil, are you still working on the 3.x version of the patch?
Sorry for the delay. I got to work on it. Shall start and shall try
to get it in soon.
--
___
Python tracker rep...@bugs.python.org
Craig McQueen ces-...@mcqueen.id.au added the comment:
@gregory.p.smith:
This change is not suitable for back porting as it arguably adds a new
feature.
Speaking as a Mercurial user who can't use Mercurial at work through a
proxy firewall... I beg you to consider that fixing this is not
Senthil orsent...@gmail.com added the comment:
Craig McQueen comment:
Speaking as a Mercurial user who can't use Mercurial at work through a
proxy firewall... I beg you to consider that fixing this is not really
We might have to take this up at python-dev. I shall do that
to get other
Andrew Trick andrew.tr...@gmail.com added the comment:
With this patch, I continued to get the following error
SSL23_GET_SERVER_HELLO
Until my coworker finally found a fix posted by Philippe Biondi:
+++ b/mercurial/keepalive.py
@@ -237,6 +237,8 @@
else:
# no
Senthil orsent...@gmail.com added the comment:
AndrewTrick: I am assuming your last comment is more relevant to
mercurial's use of the set_tunnel, the facility provided by the patch,
that is solving the issue for you. You had earlier pointed out
mercurial's dependency upon this issue too.
The
Andrew Trick andrew.tr...@gmail.com added the comment:
I should have pointed out that my secondary problem was a mercurial
dependency on the urllib patch. I just wanted Mercurial users to get a
complete fix. I figure they will be looking for a fix in the python bug
report, and need to be told
Senthil orsent...@gmail.com added the comment:
Fixed for Py2x in the revision 72880. Tested it on a Squid Proxy setup
and found it working fine. Should this be backported?
For Py3k, the Request class has undergone changes since the patch was
developed, I am modifying the patch for Py3k to
Gregory P. Smith g...@krypto.org added the comment:
I added a versionadded: 2.7 note to the docs in r72890.
This change is not suitable for back porting as it arguably adds a new
feature.
--
___
Python tracker rep...@bugs.python.org
James Broadhead jamesbroadh...@gmail.com added the comment:
Has there been any progress on this since January?
It is causing/affecting:
http://www.selenic.com/mercurial/bts/issue967
--
nosy: +jamesbroadhead
___
Python tracker
Hans L h...@velum.net added the comment:
These patches (well, the 2.6 patch) works for me. If there's something
I can do to help get this accepted/applied, I'd be happy to do it.
Obviously, I had no part in these patches, but I can take a stab at
updating documentation or something if that is
Facundo Batista facu...@taniquetil.com.ar added the comment:
Hans, please take a look to my comment 79573 in this same bug. If you
could do that, it'd be amazing...
Thank you!
--
___
Python tracker rep...@bugs.python.org
Hans Lellelid h...@velum.net added the comment:
Sure -- I will tackle that this week; I hope I can come up with
something satisfactory. As I have not provided doc patches before for
Python I may need to spin up a bit on that (and of course on the exact
meaning of the set_tunnel method in this
Senthil orsent...@gmail.com added the comment:
Sorry for the delay. I know that patches work and I had tested them as
well. I shall push those patches to trunk/p3k within this week.
--
___
Python tracker rep...@bugs.python.org
Senthil orsent...@gmail.com added the comment:
Facundo Batista facu...@taniquetil.com.ar added the comment:
Hans, please take a look to my comment 79573 in this same bug. If you
could do that, it'd be amazing...
Oops, had missed that one.. Shall update the patch, Facundo.
--
Gregory P. Smith g...@krypto.org added the comment:
reassigning to the volunteer to get this in :)
--
assignee: facundobatista - orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
Changes by Alexander Solovyov pira...@piranha.org.ua:
--
nosy: +piranha
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
___
___
Changes by Hans L h...@velum.net:
--
nosy: +hozn
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
___
___
Python-bugs-list mailing list
Changes by Elliot Murphy elliot.mur...@gmail.com:
--
nosy: +statik
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
___
___
Python-bugs-list
Changes by Daniel Diniz aja...@gmail.com:
--
nosy: +jjlee
stage: - test needed
type: - feature request
versions: -Python 2.6, Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
Changes by Daniel Diniz aja...@gmail.com:
--
stage: test needed - patch review
type: feature request - behavior
versions: +Python 2.6, Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1424152
Facundo Batista facu...@taniquetil.com.ar added the comment:
Everything looks ok, with one detail, the new set_tunnel() function.
Should this function be public? If yes, new documentation should be
added. If not, it should start with _.
I think that it should be public, because we're using it
Gregory P. Smith [EMAIL PROTECTED] added the comment:
We need make sure this happens for 2.7/3.1.
As its large enough to be a new feature it won't make it into
2.4/2.5/2.6/3.0.
--
nosy: +gregory.p.smith
priority: normal - high
versions: +Python 2.7, Python 3.1 -Python 2.4
Senthil [EMAIL PROTECTED] added the comment:
I agree, gregory. I had verified the fix and supplied patch for py2.6
and py3K. If those still apply to the trunk, I think we should go ahead,
otherwise I shall come with the new patch for 2.7/3k.
___
Python
Changes by jan matejek [EMAIL PROTECTED]:
--
nosy: +matejcik
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
___
___
Python-bugs-list mailing
Christian Kassab [EMAIL PROTECTED] added the comment:
Python 2.4.3 also doesn't support ssl and a proxy to be used at the same
time in CentOS 5.1. This file addresses the issues. It has been tested
by using YUM to access a repository through a proxy using ssl client
certificates. YUM itself
Senthil [EMAIL PROTECTED] added the comment:
As indicated by other posters, this *IS A* serious issue with urllib2 as
it does not do CONNECT for HTTPS through Proxy and it fails.
chrisl, I verified your patch and it works properly. I made some minor
changes (make a method private and changes
Changes by Senthil [EMAIL PROTECTED]:
--
components: +Library (Lib) -None
versions: +Python 2.6, Python 3.0
Added file: http://bugs.python.org/file11333/issue1424152-py3k.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
Senthil [EMAIL PROTECTED] added the comment:
Test issue1424152-py26-test_urllib2net.diff and
issue1424152-py3k-test_urllib2net.diff patches has a dependency on
Issue1251 for failure scenarios.
Issue1251 deals with ssl module not support non-blocking handshakes. So,
when the HTTPS environment is
Changes by Senthil [EMAIL PROTECTED]:
Added file:
http://bugs.python.org/file11335/issue1424152-py3k-test_urllib2net.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
___
Changes by Jesús Cea Avión [EMAIL PROTECTED]:
--
nosy: +jcea
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
___
___
Python-bugs-list mailing
Andrew Trick [EMAIL PROTECTED] added the comment:
Mercurial will not work for anyone in a large company without this
fix. I appreciate the patch, but hope its released soon. I did try the
patch with Mercurial, but now I'm getting different error. I'm not
sure if its related to the same bug:
Martin Wilck [EMAIL PROTECTED] added the comment:
I am not in my office. I'll be back on August 25, 2008.
In urgent cases, please contact:
Peter Pols [EMAIL PROTECTED] or
Gerhard Wichert [EMAIL PROTECTED]
Best regards
Martin Wilck
Added file: http://bugs.python.org/file3/unnamed
Changes by Antoine Pitrou [EMAIL PROTECTED]:
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Antoine Pitrou [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file3/unnamed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
___
Senthil [EMAIL PROTECTED] added the comment:
Senthil, could you handle this?
Sure, I shall take this up, Facundo.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
___
Changes by Facundo Batista [EMAIL PROTECTED]:
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Facundo Batista [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file10632/unnamed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
___
Facundo Batista [EMAIL PROTECTED] added the comment:
I see that you're working on a final solution, this is great!
What we would need also to incorporate this to the trunk is a patch for
the test suite. Senthil, could you handle this?
--
assignee: - facundobatista
nosy:
Nagy Ferenc László [EMAIL PROTECTED] added the comment:
Can you please try this patch on top of the original patch?
It makes an infinite loop:
Traceback (most recent call last):
File F:\nfl\proxyhttps\test.py, line 8, in module
response = urllib2.urlopen(req)
File
Martijn Pieters [EMAIL PROTECTED] added the comment:
I've created a python 2.4 compatible distribution of the python 2.5
urllib2 and httplib modules with the patch attached to this issue. This
has proven especially useful in zc.buildout or other setuptools
environments:
Christopher Li [EMAIL PROTECTED] added the comment:
Hi NL,
Can you please try this patch on top of the original patch?
Thanks
Chris
--- .pc/fix-up/urllib2.py 2008-02-06 01:13:10.0 -0800
+++ urllib2.py 2008-06-27 15:45:34.0 -0700
@@ -253,7 +253,7 @@ class Request:
Mathias Behrle [EMAIL PROTECTED] added the comment:
Just supporting, that proxy support over https is widely used and
important. I am wondering, why this request is open for more than 2 years.
Mathias
--
nosy: +matb
___
Python tracker [EMAIL
Martin Wilck [EMAIL PROTECTED] added the comment:
I am not in my office. I'll be back on June 30, 2008.
In urgent cases, please contact:
Peter Pols [EMAIL PROTECTED] or
Gerhard Wichert [EMAIL PROTECTED]
Best regards
Martin Wilck
Added file: http://bugs.python.org/file10632/unnamed
Cameron Simpson [EMAIL PROTECTED] added the comment:
Well I've happily done lots of SOAP transations, admittedly all to the
same webservice, via HTTPS-over-proxy-CONNECT using ChrisL's patch. It
seems to work just fine. Whom do we petition to get this into the
mainline python sources?
- Cameron
Changes by Cameron Simpson [EMAIL PROTECTED]:
--
nosy: +cameron
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
_
___
Python-bugs-list mailing list
Cameron Simpson [EMAIL PROTECTED] added the comment:
Chris, I'm trying your patch out now. My quick reading of it looks ok.
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
_
Changes by Peter Poeml [EMAIL PROTECTED]:
--
nosy: +poeml
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
_
___
Python-bugs-list mailing list
Changes by Dave Peterson [EMAIL PROTECTED]:
--
nosy: +dpeterson
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
_
___
Python-bugs-list mailing list
Christopher Li [EMAIL PROTECTED] added the comment:
In cast it is not obvious. I already attached the purpose patch
http-tunnel-urllib in the bug.
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
_
Changes by Chris Morgan [EMAIL PROTECTED]:
--
nosy: +mihalis68
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
_
___
Python-bugs-list mailing list
Christopher Li [EMAIL PROTECTED] added the comment:
Hi,
I am working on a patch to implement the https proxy support for
urllib2. It works fine for me, but feel free to change the patch.
Can any one take a look please?
Thanks
--
nosy: +chrisl
Added file:
Martin Wilck added the comment:
The recipe in its current form doesn't work with urllib2 in python 2.5
The reason it fails is that the HTTPConnection.request() method isn't
passed the request itself (with the proxy host and port info). No easy
solution to be seen.
--
nosy: +mwilck
Changes by vila:
--
nosy: +vila
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1424152
_
___
Python-bugs-list mailing list
Unsubscribe:
69 matches
Mail list logo
