Andrew Svetlov andrew.svet...@gmail.com added the comment:
I agree with Roger's patch.
But I'm pretty sure Ankit had another problem just because IDLE shell works for
everyone without that patch.
--
___
Python tracker rep...@bugs.python.org
Roger Serwy roger.se...@gmail.com added the comment:
IDLE contains keyboard configuration in config-keys.def (Mac, Windows, UNIX)
and in configHandler.py.
GetCoreKeys contains the keyBindings dict which has fall-back values in case
the given key set is missing values (a warning is printed).
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 26b2407c644e by Andrew Svetlov in branch '3.2':
Issue #14409: IDLE doesn't not execute commands from shell with default
keybinding for Return.
http://hg.python.org/cpython/rev/26b2407c644e
--
nosy:
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 87ada87057a2 by Andrew Svetlov in branch '2.7':
Backport of Issue #14409 to 2.7
http://hg.python.org/cpython/rev/87ada87057a2
--
___
Python tracker rep...@bugs.python.org
Andrew Svetlov andrew.svet...@gmail.com added the comment:
Roger, now your solution is completely clean for me.
I pushed your patch to 2.7, 3.2 and 3.3 branches.
Thank you.
--
assignee: - asvetlov
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14409
___
___
Ned Deily n...@acm.org added the comment:
(Thanks for the expanded analysis, Roger. I missed the implication of the title
update you made.)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14409
Roger Serwy roger.se...@gmail.com added the comment:
Thank you for the configuration files. It helped with finding the bug.
The default key bindings in configHandler.py is incorrect for
newline-and-indent which caused the problem Ankit experienced. This
problem affects the 2.7 and 3.3
Ned Deily n...@acm.org added the comment:
Roger, I notice that the line your patch modifies in configHandler.py has been
unchanged for years and is the same in older Python versions. My impression
from Ankit's description is that this is a new problem. What's different or am
I
Roger Serwy roger.se...@gmail.com added the comment:
Ned, the buggy default keybinding for newline-and-indent requires that
Key-Return and then Key-KP_Enter be pressed before the virtual event triggers.
This happens because both key events are present in a single string. The
correct behavior
10 matches
Mail list logo