[issue1451] SSL patch for Python 3000

2007-11-15 Thread Bill Janssen
Bill Janssen added the comment: Looks like the Python SVN cert did not get included in the patch, which is causing a failure. I'll check that in. __ Tracker <[EMAIL PROTECTED]> __ ___

[issue1451] SSL patch for Python 3000

2007-11-15 Thread Bill Janssen
Bill Janssen added the comment: OK, it's checked in. Let's see what the Windows buildbots think :-). Bill On Nov 15, 2007 1:35 PM, Bill Janssen <[EMAIL PROTECTED]> wrote: > > Bill Janssen added the comment: > > I'll check it in this afternoon -- I've just got to figure out how to > run the Pyt

[issue1451] SSL patch for Python 3000

2007-11-15 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks! To be continued in issue 1378... -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ _

[issue1451] SSL patch for Python 3000

2007-11-15 Thread Bill Janssen
Bill Janssen added the comment: I'll check it in this afternoon -- I've just got to figure out how to run the Python clean-up tool. Then you can check in the socket3.diff patch, then I'll make sure the SSL module works with that version of sockets. Bill On 11/15/07, Guido van Rossum <[EMAIL PR

[issue1451] SSL patch for Python 3000

2007-11-15 Thread Guido van Rossum
Guido van Rossum added the comment: If you haven't checked this in by tomorrow morning, I'll submit issue 1378 (socket3.diff) first, and you'll have to do a bunch of cleanup. Or, if you like, I can submit that now and you can do the cleanup this afternoon. (Basically, we can dup() sockets on Wi

[issue1451] SSL patch for Python 3000

2007-11-15 Thread Guido van Rossum
Guido van Rossum added the comment: Looks good (after skimming). Some stylistic nits: - Please fold lines >= 80 chars. - Please strip trailing whitespace (for Python code, you won't be allowed to submit with it present). - You can fold long imports without using the dreaded backslash now, e.g.

[issue1451] SSL patch for Python 3000

2007-11-15 Thread Bill Janssen
Bill Janssen added the comment: I've tried several different times to fix that warning. It appears on some releases of gcc, and not on others. There seems to be no cast or declaration that fixes it everywhere. More power to you if you can find one! Bill On 11/15/07, Christian Heimes <[EMAIL

[issue1451] SSL patch for Python 3000

2007-11-15 Thread Bill Janssen
Bill Janssen added the comment: Actually, it's some combination of the version of OpenSSL plus the version of gcc. Bill On 11/15/07, Bill Janssen <[EMAIL PROTECTED]> wrote: > I've tried several different times to fix that warning. It appears on > some releases of gcc, and not on others. There

[issue1451] SSL patch for Python 3000

2007-11-15 Thread Christian Heimes
Christian Heimes added the comment: Ubuntu Linux 7.10, x86, gcc version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2) /home/heimes/dev/python/py3k/Modules/_ssl.c: In function '_get_peer_alt_names': /home/heimes/dev/python/py3k/Modules/_ssl.c:680: warning: passing argument 2 of 'ASN1_item