Éric Araujo added the comment:
.. deprecated:: 1.6
This looks weird to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
___
___
Chris Rebert added the comment:
Here's a revised patch against the default branch (3.4 I presume?).
--
Added file: http://bugs.python.org/file27760/subprocess.rst-default.diff
___
Python tracker rep...@bugs.python.org
Changes by Chris Rebert pyb...@rebertia.com:
Removed file: http://bugs.python.org/file27197/subprocess.rst-3.3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
___
Chris Rebert added the comment:
Just to keep the ball rolling, in case it ends up being the solution ultimately
chosen, here is a patch against 2.7 to document pipes.quote(). The text is
yanked straight from shlex.quote(), the differences being:
- qualify shlex.split() references
- print
Roundup Robot added the comment:
New changeset f9d11ca3ccd1 by Andrew Svetlov in branch '3.3':
Issue #14616: Mention shlex.quote in subprocess docs.
http://hg.python.org/cpython/rev/f9d11ca3ccd1
New changeset 72672cf5d850 by Andrew Svetlov in branch 'default':
Merge issue #14616: Mention
Roundup Robot added the comment:
New changeset d9ca966cd116 by Andrew Svetlov in branch '2.7':
Issue #14616: Document pipes.quote and mention this one in subprocess docs.
http://hg.python.org/cpython/rev/d9ca966cd116
--
___
Python tracker
Andrew Svetlov added the comment:
I have applied all patches. Thanks, Chris.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
Chris Rebert added the comment:
No, the thought merely did not occur to me. I don't recall having seen such
forward-looking notes in Python's documentation before.
Should the pipes.quote() mention be axed from the 3.x patch?
--
___
Python tracker
Andrew Svetlov added the comment:
I think patch for 3.3 should mention only shlex.quote.
I don't care about 2.7 patch but it looks good to me.
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
Ezio Melotti added the comment:
I think patch for 3.3 should mention only shlex.quote.
+1
I'm not sure what's the best thing to do about pipes.quote. Pointing to an
undocumented function that is available in 3.3 in a different module doesn't
sound like a really good idea.
Maybe we could
Éric Araujo added the comment:
You thought it was better not to mention that pipes.quote is semi-official and
becomes public as shlex.quote in 3.3?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
Changes by Chris Rebert pyb...@rebertia.com:
Added file: http://bugs.python.org/file27196/subprocess.rst-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
___
Chris Rebert added the comment:
Updated patches to mention pipes.quote().
--
Added file: http://bugs.python.org/file27197/subprocess.rst-3.3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
Éric Araujo mer...@netwok.org added the comment:
Text LGTM; I haven’t looked at the position in the doc file though. Sandro,
once again I’m adding you to nosy in the hope that you’ll have time to make a
review and maybe a commit, with my thanks!
--
nosy: +sandro.tosi
Éric Araujo mer...@netwok.org added the comment:
Please also take my note about pipes.quote in my OP into account.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
___
Chris Rebert pyb...@rebertia.com added the comment:
Patch to mention shlex.quote() in the `subprocess` module's Frequently Used
Arguments Warning box. Could perhaps be a separate Note, but that could be
clutter-y.
--
keywords: +patch
Added file:
Changes by Tshepang Lekhonkhobe tshep...@gmail.com:
--
nosy: +tshepang
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
___
___
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
___
___
Python-bugs-list
New submission from Éric Araujo mer...@netwok.org:
The warning at
http://docs.python.org/library/subprocess#frequently-used-arguments should IMO
recommend using shlex.quote. Even if it strongly advises against using
shell=True, there are people who need or want to use it, so let’s give them
19 matches
Mail list logo
