Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset f9344a3eaaa6 by Mark Dickinson in branch 'default':
Issue #14695: Run Tools/parser/test_unparse.py as part of test_tools.
http://hg.python.org/cpython/rev/f9344a3eaaa6
--
nosy: +python-dev
Mark Dickinson dicki...@gmail.com added the comment:
Thanks, David!
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14695
___
Changes by Mark Dickinson dicki...@gmail.com:
--
assignee: - mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14695
___
___
Mark Dickinson dicki...@gmail.com added the comment:
Ah, that's good to know. I think I'll commit the fix and then look into
hooking test_unparse into test_tools.
For 3.2, it turns out that all that's missing is support for Starred.
--
___
Python
Mark Dickinson dicki...@gmail.com added the comment:
Committed in revision c80576303892 (3.2), revision 89e928048903 (default). (I
put 14965 instead of 14695 in the commit messages by mistake.)
--
___
Python tracker rep...@bugs.python.org
Mark Dickinson dicki...@gmail.com added the comment:
David: Any suggestions for how best to integrate test_unparse.py into
test_tools?
We could move the contents of test_unparse.py directly in test_tools.py and
just kill the old test_unparse.py.
Alternatively, we could import those TestCase
R. David Murray rdmur...@bitdance.com added the comment:
Since we are already doing path hackery in that test file to get things to run,
I think your patch would be fine.
If we grow more tests for the stuff in Tools (which would be good), we might
want to consider reorganizing things, but for
R. David Murray rdmur...@bitdance.com added the comment:
There is a test_tools file now. test_unparse could be called from it.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14695
New submission from Mark Dickinson dicki...@gmail.com:
Here's a patch that makes all tests in Tools/parser/test_unparse.py pass on the
default branch. (The 'yield from' bits would have to be removed for 3.2.)
--
components: Demos and Tools
files: unparse.patch
keywords: patch
