A.M. Kuchling added the comment:
#17898 has been closed with basically the same fix as Mark's patch, so I'll
close this issue.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
A.M. Kuchling added the comment:
I think that #17898 is in fact a duplicate of this bug, due to old values of k
and v confusing things. Mark's patch looks correct to me, but the patch in
#17898 also adds a test. If that patch gets reviewed, I'll apply it to
3.4/3.5, and possibly to 2.7.
Changes by Jakub Wilk jw...@jwilk.net:
--
nosy: +jwilk
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
___
Python-bugs-list mailing list
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
___
Changes by Éric Araujo mer...@netwok.org:
--
dependencies: +Add tests for some scripts in Tools/scripts
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
Changes by Éric Araujo mer...@netwok.org:
--
dependencies: -Add tests for some scripts in Tools/scripts
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
Dirkjan Ochtman dirk...@ochtman.nl added the comment:
Okay, I've filed issue12425.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
Dirkjan Ochtman dirk...@ochtman.nl added the comment:
This looks similar to https://bugs.gentoo.org/show_bug.cgi?id=373115. Is it the
same thing, or should I file a separate bug for it? (Sorry, I don't intend to
hijack this bug, but I don't know much about gettext and the patch here looks
Martin v. Löwis mar...@v.loewis.de added the comment:
It's difficult to tell whether it's the same thing. Is the po file in question
available readily for inspection?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
Dirkjan Ochtman dirk...@ochtman.nl added the comment:
Looks like this was the problem:
http://git.fedorahosted.org/git/?p=virt-manager.git;a=commitdiff;h=cb56316cf3702f03b05e30f406ff3028e45f7bfb.
E.g., the empty Plural-Forms header is throwing off the python gettext parser.
--
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
Martin v. Löwis mar...@v.loewis.de added the comment:
Ok. This is a different issue, then.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: +Python 3.3 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
___
Changes by Ricky Zhou ri...@rzhou.org:
--
nosy: +ricky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
___
Python-bugs-list mailing list
Changes by Éric Araujo mer...@netwok.org:
--
nosy: -BreamoreBoy
resolution: accepted -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
Éric Araujo mer...@netwok.org added the comment:
Could you follow the guidelines at http://www.python.org/dev/patches/ to create
patches? Thanks in advance.
I wonder why you call tearDown from setUp. Doesn’t unittest do that for you
when there is a failure in setUp? Also, you could use a
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Point taken I'll settle for PluralFormsTest unless there's a better idea.
Assuming patch acceptance could a committer do this please?
--
___
Python tracker rep...@bugs.python.org
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +merwok
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
___
___
Python-bugs-list mailing
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Attached patch is my take on the fix to this, it's a two line change to
gettext.py for 2.7. If the change is accepted I'll provide another patch for
py3k. Nosy list updated while I'm at it.
--
nosy: +BreamoreBoy, dsegan,
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Sorry, forgot to say that the patched code passed all tests in the patched unit
test file.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
Senthil Kumaran orsent...@gmail.com added the comment:
Minor change request.
+class Bug1448060(GettextBaseTest):
Can you name the test class something more meaningful like PluralFormsTest or
something like that. It is helpful when looking at it later. (Btw, this can be
done by the committer
21 matches
Mail list logo
