Hynek Schlawack h...@ox.cx added the comment:
The patch LGTM, but Pam seemed to have problems to find your account
(http://mail.python.org/pipermail/python-committers/2012-May/002037.html) – did
you get the reply and followed up on that?
--
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 9e64084f9980 by Hynek Schlawack in branch 'default':
#14835: Make plistlib output empty arrays dicts like OS X
http://hg.python.org/cpython/rev/9e64084f9980
--
nosy: +python-dev
Hynek Schlawack h...@ox.cx added the comment:
Thank you for your contribution!
But please help Pam to work out your contribution form.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Sidney San Martín s...@sidneysm.com added the comment:
Thanks Hynek, awesome! It looks like it’s in now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14835
___
Sidney San Martín s...@sidneysm.com added the comment:
Hynek: Here you go!
Ronald: Emailed it in on Friday.
--
Added file: http://bugs.python.org/file25734/plistlib_empty_element_test.patch
___
Python tracker rep...@bugs.python.org
Hynek Schlawack h...@ox.cx added the comment:
Sidney, would you mind adding a regression test for both cases?
Ned, Ronald what's your take on this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14835
Ronald Oussoren ronaldousso...@mac.com added the comment:
The patch looks fine, but as you noticed there should be a test case for this.
I'm -1 w.r.t. applying this to 3.2 or 2.7, it is a functional change that isn't
a bug (Apple's libraries will happily read empty arrays that are written as
Ronald Oussoren ronaldousso...@mac.com added the comment:
Sidney: Would you be willing to sign the contributor agreement? The following
page contains more information on the agreement:
http://www.python.org/psf/contrib/
--
___
Python tracker
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
stage: - patch review
versions: -Python 3.1, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14835
___
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14835
___
___
Python-bugs-list mailing
New submission from Sidney San Martín s...@sidneysm.com:
plistlib’s output is currently byte-for-byte identical to Apple’s, except
arrays and dictionaries are stored with self-closing tags (e.g. 'array/') and
plistlib outputs empty tags with a newline (e.g. 'array\n/array').
This tiny patch
11 matches
Mail list logo
