Terry J. Reedy added the comment:
Opened #36058 for followup.
--
resolution: -> fixed
stage: test needed -> resolved
status: open -> closed
superseder: -> Improve file decoding before re.search
versions: -Python 3.5
___
Python tracker
Terry J. Reedy added the comment:
As the 'crash' seems to have been solved, this should probably be closed and a
new issue about encodings opened. Also, since the re module used to search
lines within files can work with both bytes and strings, there might be an
option to search undecoded
Changes by Terry J. Reedy tjre...@udel.edu:
--
stage: needs patch - test needed
versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14929
Terry J. Reedy added the comment:
The 'In files:' field specifies the search directory. I opened #21960 about it
being more informative when using Find in Files from the Shell window.
Perfect encoding detection is a fantasy; decent encoding detection by
heuristics is slow and not something to
Francisco Gracia fgragu...@gmail.com added the comment:
While your are at it, here is another suggestion: what the *Find in files ...*
dialog needs most urgently in my opinion is a field for specifying clearly the
directory from which the user wants to launch the search.
Also in my modest
New submission from Francisco Gracia fgragu...@gmail.com:
There is little more that I can add to the title statement.
1. Start IDLE
2. Go to *Edit* menu option
3. Select *Find in files...* option
4. Put some word in the *Find* input box
5. Press *Search files* button
When the
Roger Serwy roger.se...@gmail.com added the comment:
When running IDLE from the terminal on Ubuntu, I get the following error:
Exception in Tkinter callback
Traceback (most recent call last):
File /home/serwy/python/cpython/Lib/tkinter/__init__.py, line 1442, in
__call__
return
Roger Serwy roger.se...@gmail.com added the comment:
The GrepDialog opens a file using plain open, without specifying the encoding
or how to handle errors. The docs for open says that the default encoding is
platform dependent (whatever locale.getpreferredencoding() returns)... This
can be
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 12454f78967b by Terry Jan Reedy in branch '3.2':
Issue14929: Stop Idle 3.x from closing on Unicode decode errors when grepping.
http://hg.python.org/cpython/rev/12454f78967b
New changeset 058c3099e82d by Terry Jan
Terry J. Reedy tjre...@udel.edu added the comment:
Interesting -- and nasty. I have used this successfully with both 3.2 and now
3.3 on Win7 to search idlelib/*.py files and on a directory of my own files,
all written by Idle and been quite pleased with the speed.
I just tried searching
Terry J. Reedy tjre...@udel.edu added the comment:
Hit send too soon;-). With that much done, we can think about a more complete
fix. See last paragraph above. Also, perhaps dialog box could have encodings
field. People should be able to grep python code for any legal identifier, and
this
11 matches
Mail list logo
