Chris Jerdonek chris.jerdo...@gmail.com added the comment:
FYI, I created issue 15299 and issue 15297 which also relate to
pkgutil.walk_packages() not working correctly in Python 3.3 -- even with the
caveat added by Brett. These two issues are in pkgutil.walk_packages()'s code
path when
Chris Jerdonek chris.jerdo...@gmail.com added the comment:
As someone who isn't an expert on Python's import mechanisms, I'm confused by
this comment at the end of pkgutil.walk_packages():
Note: Only works for importers which define a iter_modules() method, which is
non-standard but
Eric Snow ericsnowcurren...@gmail.com added the comment:
Importers are a PEP 302 API. In the context of pkgutil, they are path hooks
(see http://www.python.org/dev/peps/pep-0302/#id24), aka path importers. A
path hook is a callable that takes a path and returns a finder. Path hooks are
Chris Jerdonek chris.jerdo...@gmail.com added the comment:
Thanks a lot, Eric. I'm going to create a new issue to clarify the note a bit,
if that's okay. At minimum, I feel like enough information should be given to
let one run the examples given.
By the way, your comment, While you can use
Chris Jerdonek chris.jerdo...@gmail.com added the comment:
I created issue 15288 to improve the documentation around this.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14982
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset b92fa1c5a96b by Brett Cannon in branch 'default':
Closes issue #14982: Document that pkgutil's walk_packages() and
http://hg.python.org/cpython/rev/b92fa1c5a96b
--
nosy: +python-dev
Changes by Brett Cannon br...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14982
___
Paul Nasrat pnas...@gmail.com added the comment:
We've taken a simpler approach avoiding walk_packages in pip which we'll
release for 3.3. I'd say if pkgutil doesn't work correctly with importers
loaders outside of it we probably should make that very explicit in the docs,
and potentially
Brett Cannon br...@python.org added the comment:
Yes, the docs should get updated and I will do that before Python 3.3 goes out
the door.
--
assignee: - brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14982
Chris Jerdonek chris.jerdo...@gmail.com added the comment:
See also issue 14787 re: walk_packages(), which also affects versions before
3.3.
--
nosy: +cjerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14982
Brett Cannon br...@python.org added the comment:
I should mention that Guido and others on python-dev mentioned coming up with
an API for finders/loaders that allowed for file-like API and possibly being
able to iterate over available modules when importlib's bootstrapping landed
(sorry,
Marc Abramowitz msabr...@gmail.com added the comment:
[last: 0] marca@scml-marca:~/dev/git-repos/pip$ python3.3
Python 3.3.0a4 (v3.3.0a4:7c51388a3aa7, May 30 2012, 16:58:42)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type help, copyright, credits or license for more information.
Changes by Ronan Lamy ronan.l...@gmail.com:
--
nosy: +Ronan.Lamy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14982
___
___
Python-bugs-list
Brett Cannon br...@python.org added the comment:
Basically pkgutil kind of handles importers properly, kind of doesn't. So if a
module defined a __loader__ it will use it, but all the rest of its code
assumes it uses only the loaders defined in pkgutil.
The problem here is that
Paul Nasrat pnas...@gmail.com added the comment:
Ok so it seems I can't just use sys.meta_path in pip to work with ImpImporter
due to according to the pydoc:
Note that ImpImporter does not currently support being used by placement on
sys.meta_path.
I guess I can write a custom importer in
New submission from Marc Abramowitz msabr...@gmail.com:
I noticed that pip wasn't working properly on Python 3.3a - notably, it wasn't
able to load any of its own VCS modules -- it does this by using
pkgutil.walk_packages
I think the problem is that the behavior of pkgutil.walk_packages
Paul Nasrat pnas...@gmail.com added the comment:
I stepped through in pdb
(Pdb) p i
_frozen_importlib.FileFinder object at 0x101066090
(Pdb) iter_importer_modules(i, prefix)
[]
(Pdb) p hasattr(importer, 'iter_modules')
False
2.7 uses
[pkgutil.ImpImporter instance at 0x107a4d830]
(Pdb) pp
Eric V. Smith e...@trueblade.com added the comment:
I don't think this is related to PEP 420. Adding Brett.
--
nosy: +brett.cannon, eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14982
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14982
___
Marc Abramowitz msabr...@gmail.com added the comment:
Here's the pip issue: https://github.com/pypa/pip/issues/556
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14982
___
Paul Nasrat pnas...@gmail.com added the comment:
I was pretty tired when debugging last night and just quickly looked at hg
logs, so that may be misattributed.
I'll try come up with a clearer reproducer.
--
___
Python tracker rep...@bugs.python.org
21 matches
Mail list logo
