Serhiy Storchaka added the comment:
Thank you Arfrever. That was copy-pasted old typo. Fixed in 3d5bf6174c4b and
bc6ed8360312.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
Arfrever Frehtes Taifersar Arahesis added the comment:
In Objects/stringlib/codecs.h in 2 comments U+DC800 should be changed into
U+D800 (from definition of Py_UNICODE_IS_SURROGATE) or U+DC80 (from result of
b\x80.decode(errors=surrogateescape)).
--
Roundup Robot added the comment:
New changeset 80cf7723c4cf by Serhiy Storchaka in branch 'default':
Issue #15027: The UTF-32 encoder is now 3x to 7x faster.
https://hg.python.org/cpython/rev/80cf7723c4cf
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
And that's not all...
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
Serhiy Storchaka added the comment:
Can I commit the patch now Larry?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
___
Larry Hastings added the comment:
We're still in alpha, so it's fine for 3.5 right now. The cutoff for new
features for 3.5 will be May 23.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
Mark Lawrence added the comment:
As this appears to be a performance improvement only can it go into 3.5 or do
we wait for 3.x?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: -Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
___
Python-bugs-list
Larry Hastings added the comment:
BreamoreBoy: why did you remove Arfrever from this issue?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
Charles-François Natali added the comment:
BreamoreBoy: why did you remove Arfrever from this issue?
Noisy lists members are sorted by alphabetical order: since Arfrever comes just
before BreamoreBoy, I assume his fingers tripped ;-)
--
nosy: +Arfrever, neologix
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: -BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
___
Roundup Robot added the comment:
New changeset b72c5573c5e7 by Serhiy Storchaka in branch 'default':
Issue #15027: Rewrite the UTF-32 encoder. It is now 1.6x to 3.5x faster.
http://hg.python.org/cpython/rev/b72c5573c5e7
--
nosy: +python-dev
___
Serhiy Storchaka added the comment:
Thank you Gregory for your review.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
Larry Hastings added the comment:
Isn't this a new feature?
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
___
Serhiy Storchaka added the comment:
Sorry if I have missed. Should I revert changeset b72c5573c5e7?
This patch doesn't introduce new functions and doesn't change behavior. Without
this patch the UTF-32 encoder is up to 2.5x slower in 3.4 than in 3.3 (due to
issue12892).
--
Larry Hastings added the comment:
Would you describe it as a bug fix or a security fix? If it's neither of
those things, then you need special permission to add it during beta. And
given that this patch has the possibility of causing bugs, I'd prefer to not
accept it for 3.4.
Please revert
Roundup Robot added the comment:
New changeset 1e345924f7ea by Serhiy Storchaka in branch 'default':
Reverted changeset b72c5573c5e7 (issue #15027).
http://hg.python.org/cpython/rev/1e345924f7ea
--
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: fixed -
stage: committed/rejected - patch review
status: closed - open
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
Mark Lawrence added the comment:
From http://kmike.ru/python-data-structures/ under heading DATrie Python
wrapper uses utf_32_le codec internally; this codec is currently slow and it
is the bottleneck for datrie. There is a ticket with a patch in the CPython
bug tracker
Serhiy Storchaka added the comment:
Here is updated patch, synchronized with trunk. UTF-32 encoder now checks
surrogates and therefore speedup is less (only up to 5 times). But this
compensates regression in 3.4.
On 32-bit Linux, Intel Atom N570 @ 1.66GHz:
Py3.3Py3.4patched
Gregory P. Smith added the comment:
one comment to address on the review, otherwise after addressing that I believe
this is ready to go in for 3.4.
--
nosy: +gregory.p.smith
priority: low - normal
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
priority: normal - low
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file25857/encode-utf32.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
Serhiy Storchaka added the comment:
Patch updated to 3.4.
Is anyone interested in 7x speedup of UTF-32 encoder?
--
keywords: +needs review
versions: +Python 3.4 -Python 3.3
Added file: http://bugs.python.org/file27637/encode_utf32_2.patch
___
Python
Changes by Mikhail Korobov kmik...@gmail.com:
--
nosy: +kmike
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
___
Python-bugs-list mailing
Serhiy Storchaka storch...@gmail.com added the comment:
On 32-bit Linux, Intel Atom N570 @ 1.66GHz:
Py2.7Py3.2Py3.3patched
214 (+718%) 215 (+714%) 363 (+382%) 1750 encode utf-32le 'A'*1
214 (+704%) 214 (+704%) 362 (+375%) 1720 encode utf-32le
New submission from Serhiy Storchaka storch...@gmail.com:
In pair to issue14625 here is a patch than speed up UTF-32 encoding in several
times. In addition, it fixes an unsafe check of an integer overflow.
Here are the results of benchmarking. See benchmark tools in
28 matches
Mail list logo
