Brett Cannon br...@python.org added the comment:
Thanks for the diagnosis, Stefan. Unfortunately that line is the crux of the
test. =) I will see if I can steal some time to look at the failure to see if
there is anything obvious going on.
--
___
Chris Jerdonek chris.jerdo...@gmail.com added the comment:
I could be way off (just passing through), but the test flakiness described
here seems reminiscent of a discussion we had for issue 7559. There the
solution to order-dependent tests with importlib involved calling
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 906c69928049 by Brett Cannon in branch 'default':
Issue #15210: Greatly simplify the test for supporting importlib
http://hg.python.org/cpython/rev/906c69928049
--
___
Brett Cannon br...@python.org added the comment:
I realized the problem was that _frozen_importlib was getting set to None,
which won't trigger an exception since the code was just directly accessing
sys.modules. I switched to an ``import ... as ...`` clause and moved to using
Antoine Pitrou pit...@free.fr added the comment:
Thanks Brett!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15210
___
___
Python-bugs-list
Antoine Pitrou pit...@free.fr added the comment:
Ping. The test fails erratically on many buildbots.
--
nosy: +pitrou
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15210
Brett Cannon br...@python.org added the comment:
Any suggestions on how to make the test work better? Otherwise I'm fine with
dropping the test since the fix has been verified at least on my machine (and
if it is broken the other VMs will notice quickly when they start to implement
things).
Antoine Pitrou pit...@free.fr added the comment:
Any suggestions on how to make the test work better?
I would suggest tracking what causes the failure. It seems to be
ordering-dependent, so the devguide is your friend:
http://docs.python.org/devguide/buildbots.html#ordering-dependent-failures
Stefan Krah stefan-use...@bytereef.org added the comment:
The tests that fail in succession are these:
./python -m test -uall -v test_importlib test_import
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15210
Stefan Krah stefan-use...@bytereef.org added the comment:
If I comment out this, both tests run OK (I don't know if that
breaks anything else though):
diff --git a/Lib/importlib/test/test_api.py b/Lib/importlib/test/test_api.py
--- a/Lib/importlib/test/test_api.py
+++
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 818db871d29a by Brett Cannon in branch 'default':
Issue #15210: If _frozen_importlib is not found in sys.modules by
http://hg.python.org/cpython/rev/818db871d29a
--
nosy: +python-dev
Changes by Brett Cannon br...@python.org:
--
assignee: - brett.cannon
resolution: - fixed
stage: test needed - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15210
New submission from Brett Cannon br...@python.org:
If you look at
http://hg.python.org/cpython/file/abcd29c9a791/Lib/importlib/__init__.py you
will notice that the try/except block for seeing if _frozen_importlib exists
catches ImportError, not KeyError like it should since it is checking
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15210
___
14 matches
Mail list logo