[issue1522400] irda socket support

Changes by Christian Heimes : -- versions: +Python 3.6, Python 3.7 -Python 3.4 ___ Python tracker ___

[issue1522400] irda socket support

Changes by Charles-François Natali neolo...@free.fr: -- versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1522400 ___

[issue1522400] irda socket support

Charles-François Natali neolo...@free.fr added the comment: Actually I think it suffers from the same problem as AF_UNIX: sockaddr_irda-sir_name, like sockaddr_un-sun_path, don't have to be NUL-terminated, and the kernel can return non NUL-terminated strings. Actually, I've had a look at the

[issue1522400] irda socket support

Changes by Charles-François Natali neolo...@free.fr: Added file: http://bugs.python.org/file25415/irda-default-1.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1522400 ___

[issue1522400] irda socket support

Gregory P. Smith g...@krypto.org added the comment: Your updated patch looks fine to me. I don't see any reason not to commit it and mention it in the release notes. If it has bugs, they can be discovered and fixed later by people with actual relevant hardware an interest. -- nosy:

[issue1522400] irda socket support

Charles-François Natali neolo...@free.fr added the comment: Actually I think it suffers from the same problem as AF_UNIX: sockaddr_irda-sir_name, like sockaddr_un-sun_path, don't have to be NUL-terminated, and the kernel can return non NUL-terminated strings. Which means that such code:

[issue1522400] irda socket support

Charles-François Natali neolo...@free.fr added the comment: Here's a cleanup up patch against default. However, I don't have any IrDA capable device neither, so I won't be able to help much. I'll ask on python-dev if someone can help. As for the manual decoding, AFAICT you'll have the same issue

[issue1522400] irda socket support

Changes by Martin v. Löwis mar...@v.loewis.de: -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1522400 ___ ___

[issue1522400] irda socket support

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +neologix ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1522400 ___ ___ Python-bugs-list

[issue1522400] irda socket support

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- components: +Library (Lib) -Extension Modules stage: unit test needed - patch review versions: +Python 3.2 -Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org

[issue1522400] irda socket support

Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1522400 ___ ___

[issue1522400] irda socket support

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1522400 ___ ___ Python-bugs-list mailing

[issue1522400] irda socket support

Antoine Pitrou pit...@free.fr added the comment: A new patch should be generated against 3.2 (the current one doesn't apply cleanly). Also, checking for linux/irda.h requires that sys/socket.h is included, hence needing the following snippet in configure.in: # On Linux, irda.h requires

[issue1522400] irda socket support

Antoine Pitrou pit...@free.fr added the comment: Here is a straight port of the patch to py3k, compiling under Linux and Windows. Several problems though: 1. the patch seems incomplete, in that manual decoding of return values is necessary (see posted example obex_test.py) 2. there seems to

[issue1522400] irda socket support

Changes by Brian Curtin cur...@acm.org: -- components: +Extension Modules -Library (Lib) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1522400 ___

[issue1522400] irda socket support

Changes by Daniel Diniz aja...@gmail.com: -- stage: - test needed type: - feature request versions: +Python 2.7, Python 3.1 -Python 2.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1522400