Martin Panter added the comment:
The name changes to the function parameters should be avoided without a good
reason.
I would recommend rejecting all of the changes in this patch. They are
basically changing one person’s coding style to another person’s style. I
happen to prefer list() and
R. David Murray added the comment:
I agree. The one change that has a non-style motivation (type) is one that
should not be made for backward compatibility reasons.
--
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
Michael Foord added the comment:
Code cleanups for their own sake sound like a good thing, *iff* the cleanup is
worthwhile (for example it makes debugging easier). i.e. the cleanup isn't
gratuitous but worthwhile.
This seems to be the case here and the rejected patch in issue #15137 had
Éric Araujo added the comment:
Well, here I don’t see the benefit in avoiding the use of “file”, given that
the builtin of the same name is not needed thanks to the open function
(contrary to id, type, str, string and others).
If you think our (unwritten?) policy of not doing cleanup-only
Éric Araujo mer...@netwok.org added the comment:
We don’t do code cleanups for their own sake, but rather as part of a bug fix
or feature addition. Please see #15137 for a longer explanation.
--
nosy: +eric.araujo, r.david.murray, terry.reedy
___
Brian Brazil brian.bra...@gmail.com added the comment:
This patch is a result of frustration encountered when debugging #15002.
Not being able to use 'type' directly is rather annoying, so after figuring
that bug out I set some time aside to make it easier for the next person.
This could be
Éric Araujo mer...@netwok.org added the comment:
Not being able to use 'type' directly is rather annoying, so after figuring
that bug out I set
some time aside to make it easier for the next person.
If you make a patch for #15002 then by all means rename “type” to “filetype” so
that you can
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15280
___
___
Python-bugs-list
New submission from Brian Brazil brian.bra...@gmail.com:
See attached patch, there's still self.type in places. I also converted one map
to a list comprehension.
--
components: Library (Lib)
files: urllib-request-cleanup-builtin-names.patch
keywords: patch
messages: 164874
nosy:
