[issue15351] Add to unittest.TestCase support for using context managers

Serhiy Storchaka added the comment: Opened issue45046 for completely different approach to this problem. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue15351] Add to unittest.TestCase support for using context managers

Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15351 ___ ___ Python-bugs-list

[issue15351] Add to unittest.TestCase support for using context managers

Julian Berman added the comment: Now that we have contextlib.ExitStack, I think we should consider that here. I.e., I think ExitStack deserves a method that calls its __enter__ and __exit__, say .enter() and .exit(), and then the idiom for this wouldn't require anything on TestCase, it'd be:

[issue15351] Add to unittest.TestCase support for using context managers

Changes by Chris Calloway c...@chriscalloway.org: -- nosy: +cbc ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15351 ___ ___ Python-bugs-list

[issue15351] Add to unittest.TestCase support for using context managers

Changes by Michael Foord mich...@voidspace.org.uk: -- assignee: - michael.foord ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15351 ___ ___

[issue15351] Add to unittest.TestCase support for using context managers

Changes by Eli Bendersky eli...@gmail.com: -- nosy: +eli.bendersky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15351 ___ ___ Python-bugs-list

[issue15351] Add to unittest.TestCase support for using context managers

Chris Jerdonek added the comment: Adding Éric because of the interest in test setup and tear down in issue 11664. -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15351

[issue15351] Add to unittest.TestCase support for using context managers

Chris Jerdonek chris.jerdo...@gmail.com added the comment: Attached is a patch illustrating the API I suggested for discussion. To add custom setup and teardown context managers, the user can override the following method: def executeTest(self): with self.setUpContext():

[issue15351] Add to unittest.TestCase support for using context managers

Michael Foord mich...@voidspace.org.uk added the comment: A method on TestCase that *just* executes the test method - allowing for overriding in subclasses - is an interesting idea. Including setUp and tearDown would be harder because TestCase necessarily does a bunch of bookkeeping between

[issue15351] Add to unittest.TestCase support for using context managers

New submission from Chris Jerdonek chris.jerdo...@gmail.com: The setUp() and tearDown() methods of unittest.TestCase are of course extremely useful. But sometimes one has set up and tear down functionality that one would like to apply in the form of an existing context manager (and that may

[issue15351] Add to unittest.TestCase support for using context managers

R. David Murray rdmur...@bitdance.com added the comment: Well, if you want to invoke the context in setup/teardown for some reason (as opposed to in the test methods themselves), you can do this: def setUp(self): self.foo = MyContextManager.__enter__()

[issue15351] Add to unittest.TestCase support for using context managers

R. David Murray rdmur...@bitdance.com added the comment: That should have been self.addCleanup(MyContextManager.__exit__) You could alternatively call __exit__() explicitly in tearDown, of course, but I believe addCleanup is a more reliable cleanup than tearDown. --

[issue15351] Add to unittest.TestCase support for using context managers

Chris Jerdonek chris.jerdo...@gmail.com added the comment: Thanks for the interesting background and feedback. I was aware of the __enter__/__exit__ option but not the other information. And yes, I agree on the importance of trying and discussing any API before settling on it. The one I