[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: Perfect. Thanks, Ned! I'll update the Apple issue. -- ___ Python tracker ___ ___ Python-bugs-list

[issue15477] test_cmath failures on OS X 10.8

Ned Deily added the comment: I built Python at 3fba718e46e5 on both 10.8 and 10.9 which was just before your changes for this issue went in, Mark. On 10.8: test_cmath fails and: >>> math.log1p(-0.0) 0.0 And, indeed, on 10.9, it passes and: >>> math.log1p(-0.0) -0.0 --

[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: Update: I just received this from Apple, for bug #12128251. """ We believe this issue has been addressed in OS X Mavericks GM build 13A603. Please verify with this release, and update this report with your results. """ -- _

[issue15477] test_cmath failures on OS X 10.8

Changes by alef : -- nosy: -alef ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailma

[issue15477] test_cmath failures on OS X 10.8

Changes by alef : -- nosy: +alef ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman

[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: Apple bug report filed: Bug ID# 12128251. Closing the issue. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue15477] test_cmath failures on OS X 10.8

Roundup Robot added the comment: New changeset 336653319112 by Mark Dickinson in branch 'default': Issue #15477: Merge fix from 3.2 http://hg.python.org/cpython/rev/336653319112 -- ___ Python tracker __

[issue15477] test_cmath failures on OS X 10.8

Roundup Robot added the comment: New changeset 08418369da7b by Mark Dickinson in branch '3.2': Issue #15477: Add workaround for log1p(-0.0) on platforms where it's broken. http://hg.python.org/cpython/rev/08418369da7b -- nosy: +python-dev ___ Python t

[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: > BTW, did anybody file a bug report with Apple? I'll file one. -- ___ Python tracker ___ ___ Pytho

[issue15477] test_cmath failures on OS X 10.8

Martin v. Löwis added the comment: BTW, did anybody file a bug report with Apple? Even to my untrained eye, that looks like a clear violation of the POSIX standard: If x is ±0, or +Inf, x shall be returned. http://pubs.opengroup.org/onlinepubs/009604599/functions/log1p.html C seems to make it

[issue15477] test_cmath failures on OS X 10.8

Trent Nelson added the comment: Happy to report your patch does the trick Mark. test_cmath passes on 10.7 and 10.8 with it applied. -- ___ Python tracker ___ __

[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: See also http://bugs.python.org/issue9920; the patch here *should* fix that issue, too. -- ___ Python tracker ___

[issue15477] test_cmath failures on OS X 10.8

Changes by Mark Dickinson : -- components: +Extension Modules stage: -> patch review type: -> behavior versions: +Python 2.7, Python 3.2 ___ Python tracker ___

[issue15477] test_cmath failures on OS X 10.8

Changes by Mark Dickinson : Removed file: http://bugs.python.org/file26884/log1p_sign_workaround.patch ___ Python tracker ___ ___ Python-bugs-

[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: Updated patch that also removes the sysconfig checks from the cmath tests. -- Added file: http://bugs.python.org/file26885/log1p_sign_workaround.patch ___ Python tracker __

[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: Trent, many thanks for the report and analysis. The LOG1P_DROPS_ZERO_SIGN hackery was a result of a previous attempt to 'fix' the tests on another platform whose log1p didn't preserve zero signs. But now that this behaviour has emerged on OS X too, I think i

[issue15477] test_cmath failures on OS X 10.8

Changes by Mark Dickinson : -- assignee: -> mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue15477] test_cmath failures on OS X 10.8

Trent Nelson added the comment: I ran into this last night and posted to python-dev before realizing this bug had been raised: http://mail.python.org/pipermail/python-dev/2012-August/121359.html I'll reproduce it here as I made a few observations that haven't yet been mentioned in this issue:

[issue15477] test_cmath failures on OS X 10.8

Martin v. Löwis added the comment: Without looking into the details of the issue: conditionalizing a work-around on OSX sounds right. On the one hand, it may penalize OSX releases which get it right. OTOH, it's all Apple's fault (IIUC), so they deserve it :-) Further, using a build-time check

[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: > These types of run-time tests based on configure-time tests are problematic > for binary installations of Python, like the OS X installers. Understood. I'm wondering how to fix this for Python, given that we're unlikely to see an OS-level fix for a while. T

[issue15477] test_cmath failures on OS X 10.8

Ned Deily added the comment: >>It also doesn't agree with what 'man log1p' says on my OS X 10.6 >>Macbook: under 'SPECIAL VALUES', it says: 'log1p(+-0) returns +-0.' That manpage is unchanged for 10.8. >>I'm puzzled about one thing, though: there's a test for this problem >>in the configure

[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: >>> math.log1p(0.0) 0.0 >>> math.log1p(-0.0) 0.0 Ah, that would do it, then. It looks as though the system's log1p function is buggy, in the sense that it doesn't follow C99 Annex F (F.9.3.9). It also doesn't agree with what 'man log1p' says on my OS X 10.6

[issue15477] test_cmath failures on OS X 10.8

Ned Deily added the comment: > I assume the failure still happens in debug mode? Yes > Are there any math module failures? No > What do math.log1p(0.0) and math.log1p(-0.0) give? (Answers *should* be 0.0 > and -0.0 respectively.) >>> math.log1p(0.0) 0.0 >>> math.log1p(-0.0) 0.0 >>> sysconf

[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: Also: what's HAVE_LOG1P for this build? -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue15477] test_cmath failures on OS X 10.8

Mark Dickinson added the comment: Judging by previous reports of this type, it's probably either a bug in the platform math library or a compiler optimization bug (or possibly a combination of the two: one previous OS X bug involved calls to sin / cos being 'optimized' to a badly implemented

[issue15477] test_cmath failures on OS X 10.8

New submission from Ned Deily : == FAIL: testAtanSign (test.test_cmath.CMathTests) -- Traceback (most recent call last): File "/Library/Frameworks/Python.fram