Thomas Herve added the comment:
Here it is. There were several functions which didn't have any tests at
all, so I had to create some. These tests are likely to fail on some
platforms (like windows), but I didn't get any machine to test.
Added file:
New submission from Thomas Herve:
I attach a patch where I use PyArg_ParseTupleAndKeywords in socketmodule
where ARGSUSED was mentioned, or removed ARGSUSED if keywords already used.
--
components: Library (Lib)
files: socket_keywords.diff
messages: 58189
nosy: therve
severity: normal
Martin v. Löwis added the comment:
What problem(s) does this solve?
--
nosy: +loewis
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1554
__
___
Python-bugs-list mailing
Thomas Herve added the comment:
It's not really for solving a problem, it's an enhancement to allow the
functions to be called with keyword parameters.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1554
__
Martin v. Löwis added the comment:
And what problem is solved by the removal of ARGSUSED?
For the functions whose signatures you changed, can you please add
documentation and test changes as well (where necessary)?
Please don't remove the arguments PyObject* on METHO_NOARGS functions;
that is
Thomas Herve added the comment:
Alright I'll add tests to the modified functions. I don't think I have
to change documentation because I kept the same name for the parameters,
but I'll check.
Looking at the patch more, maybe it doesn't make sense on the functions
taking only one parameter
