Christian Heimes added the comment:
The fix doesn't work for me. With make -s I still see the output to stdout.
Also there are much simpler ways to test for MAKEFLAGS:
ifneq (,$(findstring s,$(MAKEFLAGS)))
QUIET=-q
else
QUIET=
endif
then use $(QUIET) in the call to setup.py
Matthias Klose added the comment:
@benjamin: no, the extensions were never built in parallel
@christian: no, that again would match the `s' when you have something like
--jobserver in MAKEFLAGS.
--
___
Python tracker rep...@bugs.python.org
Christian Heimes added the comment:
Ah, got it. GNU sorts the arguments in MAKEFLAGS. The s flag is always in the
first word.
$ make -j4 -s
s --jobserver-fds=3,4 -j
$ make --quiet -j4
s --jobserver-fds=3,4 -j
This make code works well for me:
ifeq (s,$(findstring s,$(word 1,$(MAKEFLAGS
Matthias Klose added the comment:
even if you pass other options to make, and -s not as the first flag? and does
this work for other makes different than GNU make too? But maybe we already
require GNU make.
--
___
Python tracker
Christian Heimes added the comment:
The lines under each of my examples are the content of $MAKEFLAGS. It works
when I pass the option in a different order and even with alternative spellings
for -s like --quiet. It's always the s flag:
$ make -s --jobs=4
s --jobserver-fds=3,4 -j
$ make
Roundup Robot added the comment:
New changeset 048e13546a7c by Christian Heimes in branch '3.2':
Issue #15591: run ctypes' configure in quiet mode when setup.py runs silently
http://hg.python.org/cpython/rev/048e13546a7c
New changeset e5569b03a287 by Christian Heimes in branch 'default':
Issue
Roundup Robot added the comment:
New changeset b9261dd34289 by Christian Heimes in branch '3.2':
Issue #15591 and Issue #11715: silence output of setup.py when make is run with
-s option.
http://hg.python.org/cpython/rev/b9261dd34289
New changeset fcc629208842 by Christian Heimes in branch
Changes by Christian Heimes li...@cheimes.de:
--
nosy: +brett.cannon
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15591
___
Roundup Robot added the comment:
New changeset 8cd6acffbcb9 by Christian Heimes in branch '2.7':
Issue #15591 and Issue #11715: silence output of setup.py when make is run with
-s option.
http://hg.python.org/cpython/rev/8cd6acffbcb9
--
___
Python
Changes by Barry A. Warsaw ba...@python.org:
--
nosy: +barry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15591
___
___
Python-bugs-list mailing
Matthias Klose added the comment:
bah, this happens when you do a parallel build. --jobserver-fds is passed in
MAKEFLAGS, and the test for sharedmods turns on the quiet mode, because it
matches just *s* in MAKEFLAGS :-/
The patch tries to parse MAKEFLAGS using getopt, and if getopt is not
Roundup Robot added the comment:
New changeset 1a1d097b17e2 by Matthias Klose in branch '2.7':
- Issue #15591: Fix parsing MAKEFLAGS in the sharedmods target.
http://hg.python.org/cpython/rev/1a1d097b17e2
New changeset 763d188a96bb by Matthias Klose in branch '3.2':
- Issue #15591: Fix parsing
Matthias Klose added the comment:
fixed.
--
resolution: - fixed
status: open - closed
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15591
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15591
___
Benjamin Peterson added the comment:
This seems to have broken parallel building of modules.
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15591
___
New submission from Matthias Klose:
I see this on all Debian and Ubuntu releases, when stdout is redirected. I
expect to see the compiler and linker invocations for the sharedmods target,
but I only see stderr (compiler and linker warnings).
e.g. make 21 | tee log
or script -c 'make' log
16 matches
Mail list logo
