Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
All patches seems already applied. Should we close this issue?
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
Brian Curtin cur...@acm.org added the comment:
Closed. I created #9332 for the remaining side issues.
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Antoine Pitrou pit...@free.fr added the comment:
This has broken all non-Windows buildbots. Can you take a look?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Jason R. Coombs jar...@jaraco.com added the comment:
I'm building now and will report back shortly...
--
Added file: http://bugs.python.org/file17920/smime.p7s
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Also, GetFinalPathNameByHandle() is called 5 times with VOLUME_NAME_DOS, and
once with VOLUME_NAME_NT. This one looks suspect to me.
[I noticed this because these symbols are not defined with the SDK shipped with
VS8.0. I'll propose
Jason R. Coombs jar...@jaraco.com added the comment:
Here's a patch to address the posix failures:
- test_posixpath seems to have lost the creation of one test file.
- WindowsError doesn't exist on other platforms, so it can't be caught directly
(in tarfile.py). I've written a work-around, but
Changes by Jason R. Coombs jar...@jaraco.com:
Removed file: http://bugs.python.org/file17920/smime.p7s
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Hm, the patch could be more pythonic. Something like:
symlink_exception = (AttributeError,)
try:
symlink_exception += (NotImplementedError, WindowsError)
except NameError:
pass
try:
...
except symlink_exception:
...
Antoine Pitrou pit...@free.fr added the comment:
Hm, the patch could be more pythonic. Something like:
symlink_exception = (AttributeError,)
try:
symlink_exception += (NotImplementedError, WindowsError)
except NameError:
pass
Probably better as:
symlink_exception =
Brian Curtin cur...@acm.org added the comment:
Committed Jason's patch with Antoine's twist as r82743 after running on Arch
Linux. Thanks for catching and looking into this stuff.
--
___
Python tracker rep...@bugs.python.org
Brian Curtin cur...@acm.org added the comment:
Committed in r82659.
I'm leaving this open until a few other issues are fleshed out.
1. Document privilege escalation and/or expose some method to do so.
2. Test execution, e.g., buildbots
Once I get a few more things off my plate I should be
Jason R. Coombs jar...@jaraco.com added the comment:
This patch includes a routine that adds the directory of the python executable
to the path before attempting to run a symlinked executable (in test_platform).
--
Added file: http://bugs.python.org/file16821/windows symlink draft
Martin v. Löwis mar...@v.loewis.de added the comment:
The patch has now missed the window for 2.7, so backporting it won't be
necessary.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
Jason R. Coombs jar...@jaraco.com added the comment:
In the last patch, I addressed test_platform running a test under a symlinked
Python. I then found the same error resulting from essentially the same code in
test_sysconfig. So I refactored those methods into a generator method in
Changes by Jason R. Coombs jar...@jaraco.com:
Added file: http://bugs.python.org/file16825/windows symlink draft 29.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Changes by Jason R. Coombs jar...@jaraco.com:
Removed file: http://bugs.python.org/file16809/windows symlink draft 27.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Changes by Jason R. Coombs jar...@jaraco.com:
Removed file: http://bugs.python.org/file16821/windows symlink draft 28.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Changes by Jason R. Coombs jar...@jaraco.com:
Removed file: http://bugs.python.org/file16824/windows symlink draft 28.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Changes by Jason R. Coombs jar...@jaraco.com:
Added file: http://bugs.python.org/file16833/admin results - no patch.zip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Changes by Jason R. Coombs jar...@jaraco.com:
Added file: http://bugs.python.org/file16834/admin results - patch 29.zip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Jason R. Coombs jar...@jaraco.com added the comment:
With patch 29, I believe all patch-related test failures are corrected.
The remaining failures in some modules (namely test_tarfile, test_glob,
test_mailbox, test_warnings) can be demonstrated to occur in unpatched builds.
Since some
Changes by Jason R. Coombs jar...@jaraco.com:
Added file: http://bugs.python.org/file16835/guest results - patch 29.zip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Changes by Jason R. Coombs jar...@jaraco.com:
Removed file: http://bugs.python.org/file16202/guest results.zip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Changes by Jason R. Coombs jar...@jaraco.com:
Removed file: http://bugs.python.org/file16203/admin results.zip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Jason R. Coombs jar...@jaraco.com added the comment:
It seems issue7443 discusses the cause of the transient failures.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Jason R. Coombs jar...@jaraco.com added the comment:
While trying to reproduce the transient test_tarfile errors, I found two more
tests that appear to be failing when symlinks cannot be created, now skipped by
patch 27.
--
Added file: http://bugs.python.org/file16809/windows symlink
Jason R. Coombs jar...@jaraco.com added the comment:
I've been fighting a failing test in test_platform (when
test.support.can_symlink() is True). Turns out the problem is caused by the
fact that the Python DLL cannot be resolved when the executable isn't in the
same directory (which is the
Changes by Jason R. Coombs jar...@jaraco.com:
Removed file: http://bugs.python.org/file16196/windows symlink draft 25.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Changes by Jason R. Coombs jar...@jaraco.com:
Removed file: http://bugs.python.org/file16761/windows symlink draft 26.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
___
Jason R. Coombs jar...@jaraco.com added the comment:
My initial troubleshooting indicated to me that the intermittent test_tarfile
problem exists independent of the symlink patch, so it was not relevant to this
issue.
I've tried to do some more thorough troubleshooting, and this continues to
Jason R. Coombs jar...@jaraco.com added the comment:
This latest patch (26) only merges the latest changes from the repo.
--
Added file: http://bugs.python.org/file16761/windows symlink draft 26.patch
___
Python tracker rep...@bugs.python.org
Brian Curtin cur...@acm.org added the comment:
One last issue to solve before this goes in and I start the
backport...test_tarfile.test_extract_hardlink is intermittently failing for me,
which was an issue for Eric and I on an earlier version of Jason's patch.
Sometimes it fails when run as a
Brian Curtin cur...@acm.org added the comment:
Anyone opposed to this being checked in? Other than some style issues which
I'll fix on checkin, I believe this is ready to go. I'd like to get it in so I
can backport it to 2.7 before the beta on Saturday.
--
assignee: eric.smith -
Eric Smith e...@trueblade.com added the comment:
I had some style issues at one point, but I haven't looked at it closely
recently. I won't have time to look at this before next week, so proceed
without me.
--
___
Python tracker
sorin sorin.sbar...@gmail.com added the comment:
For me the patch worked. It would be really nice to have it in 2.7 - I really
hate Python functions that are not working on Windows.
--
___
Python tracker rep...@bugs.python.org
Eric Smith e...@trueblade.com added the comment:
At the language summit we okay'd using ctypes in the tests for standard lib
modules, specifically for this issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
36 matches
Mail list logo
