Charles-François Natali added the comment:
Here's an updated patch using the lru_cache decorator.
--
Added file: http://bugs.python.org/file31312/connect_timeout-1.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16463
Changes by Charles-François Natali cf.nat...@gmail.com:
Added file: http://bugs.python.org/file31320/connect_timeout-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16463
___
Serhiy Storchaka added the comment:
LGTM.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16463
___
___
Roundup Robot added the comment:
New changeset 5880c7d33e13 by Charles-François Natali in branch '3.3':
Issue #16463: Fix a transient test_timeout failure.
http://hg.python.org/cpython/rev/5880c7d33e13
New changeset 5d4fe1da2c90 by Charles-François Natali in branch 'default':
Issue #16463: Fix
Charles-François Natali added the comment:
Should be fixed now!
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16463
Antoine Pitrou added the comment:
Or we can wrap the resolve_address() method with the @functools.lru_cache()
decorator.
Sounds ok to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16463
Antoine Pitrou added the comment:
Ah, good point. My only issue with the patch is that www.python.org will be
resolved for every test method, even those that don't use remote_addr. This
will make test_timeout unnecessarily slower.
--
___
Python
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: ncoghlan - neologix
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16463
___
Serhiy Storchaka added the comment:
We can do this in the setUpClass() method.
Or we can wrap the resolve_address() method with the @functools.lru_cache()
decorator.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
Changes by koobs koobs.free...@gmail.com:
--
nosy: +koobs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16463
___
___
Python-bugs-list mailing
Charles-François Natali added the comment:
The problem is that the test passes a DNS address to connect(), which means
that it has to perform a name resolution first.
And since there's not timeout on gethostbyname()/getaddrinfo() you can end up
well above the timeout.
The hostnames should be
Charles-François Natali added the comment:
And here's a patch.
--
keywords: +patch
Added file: http://bugs.python.org/file31137/connect_timeout.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16463
Ned Deily added the comment:
Also fails occasionally on OS X 3.3 and 3.x with much smaller deltas:
==
FAIL: testConnectTimeout (test.test_timeout.TCPTimeoutTestCase)
13 matches
Mail list logo
