[issue16575] ctypes: unions as arguments

Vinay Sajip added the comment: New changeset 9dbf5d3bc2033940cdca35440cf08814544f81e4 by Vinay Sajip in branch '3.7': [3.7] bpo-16575: Disabled checks for union types being passed by value. (GH-17960) (GH-17970)

[issue16575] ctypes: unions as arguments

Change by Vinay Sajip : -- pull_requests: +17378 pull_request: https://github.com/python/cpython/pull/17970 ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Vinay Sajip added the comment: New changeset eb9ba2f66df2195a9c6295e73ab3d545a1445f05 by Vinay Sajip (Miss Islington (bot)) in branch '3.8': bpo-16575: Disabled checks for union types being passed by value. (GH-17960) (GH-17964)

[issue16575] ctypes: unions as arguments

Change by miss-islington : -- pull_requests: +17373 pull_request: https://github.com/python/cpython/pull/17964 ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Vinay Sajip added the comment: New changeset c12440c371025bea9c3bfb94945f006c486c2c01 by Vinay Sajip in branch 'master': bpo-16575: Disabled checks for union types being passed by value. (GH-17960) https://github.com/python/cpython/commit/c12440c371025bea9c3bfb94945f006c486c2c01 --

[issue16575] ctypes: unions as arguments

Change by Vinay Sajip : -- pull_requests: +17368 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17960 ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Vinay Sajip added the comment: It seems that notwithstanding the issues identified in the original bug report, calls by value of structs containing unions are being used out there in the wild. Examples: The comtypes library (Windows):

[issue16575] ctypes: unions as arguments

STINNER Victor added the comment: 3.7 refleaks buildbots pass again (ignoring a few warnings). -- resolution: -> fixed ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Change by Ammar Askar : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue16575] ctypes: unions as arguments

Ammar Askar added the comment: Will close after https://buildbot.python.org/all/#/builders?tags=%2Brefleak=%2B3.7 go back to green. -- ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Vinay Sajip added the comment: New changeset 484edbf9bf1a9e6bae0fcb10a0c165b89ea79295 by Vinay Sajip (Ammar Askar) in branch '3.7': bpo-16575: Fix refleak on passing unions in ctypes (GH-17064) https://github.com/python/cpython/commit/484edbf9bf1a9e6bae0fcb10a0c165b89ea79295 --

[issue16575] ctypes: unions as arguments

Ammar Askar added the comment: Opened https://github.com/python/cpython/pull/17064 to fix this. Essentially it's a tiny little oversight in the back-porting. In the 3.7 branch, we perform an attribute lookup for `from_param` before the union checking code, so we must remember to DECREF it.

[issue16575] ctypes: unions as arguments

Change by Ammar Askar : -- pull_requests: +16572 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/17064 ___ Python tracker ___

[issue16575] ctypes: unions as arguments

STINNER Victor added the comment: Same issue on x86 Gentoo Refleaks 3.7: test_ctypes leaked [174, 174, 174] references, sum=522 test_ctypes leaked [76, 78, 76] memory blocks, sum=230 https://buildbot.python.org/all/#/builders/114/builds/631 --

[issue16575] ctypes: unions as arguments

STINNER Victor added the comment: This change introduced a reference leak on Windows. Example on 3.7: https://buildbot.python.org/all/#/builders/132/builds/645 test_ctypes leaked [174, 174, 174] references, sum=522 test_ctypes leaked [76, 77, 77] memory blocks, sum=230 -- nosy:

[issue16575] ctypes: unions as arguments

Change by Vinay Sajip : -- assignee: docs@python -> vinay.sajip resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Vinay Sajip added the comment: New changeset 0118d109d54bf75c99a8b0fa9aeae1a478ac4b7e by Vinay Sajip in branch '3.7': [3.7] bpo-16575: Add checks for unions passed by value to functions. (GH-16799) (GH-17017) https://github.com/python/cpython/commit/0118d109d54bf75c99a8b0fa9aeae1a478ac4b7e

[issue16575] ctypes: unions as arguments

Vinay Sajip added the comment: New changeset 952899704800a5aa438e84d50f0b6fc498c72e89 by Vinay Sajip in branch '3.8': [3.8] bpo-16575: Add checks for unions passed by value to functions. (GH-16799) (GH-17016) https://github.com/python/cpython/commit/952899704800a5aa438e84d50f0b6fc498c72e89

[issue16575] ctypes: unions as arguments

Change by Vinay Sajip : -- pull_requests: +16536 pull_request: https://github.com/python/cpython/pull/17017 ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Change by Vinay Sajip : -- pull_requests: +16535 pull_request: https://github.com/python/cpython/pull/17016 ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Vinay Sajip added the comment: New changeset 79d4ed102a5069c6cebaed2627cb1645637f0429 by Vinay Sajip in branch 'master': bpo-16575: Add checks for unions passed by value to functions. (GH-16799) https://github.com/python/cpython/commit/79d4ed102a5069c6cebaed2627cb1645637f0429 --

[issue16575] ctypes: unions as arguments

Change by Vinay Sajip : -- pull_requests: +16355 pull_request: https://github.com/python/cpython/pull/16799 ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Change by Vinay Sajip : -- pull_requests: +16009 pull_request: https://github.com/python/cpython/pull/16430 ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Change by Vinay Sajip : -- keywords: +patch pull_requests: +15485 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15839 ___ Python tracker

[issue16575] ctypes: unions as arguments

Vinay Sajip added the comment: Link to issue has changed to: https://github.com/libffi/libffi/issues/33 -- ___ Python tracker ___

[issue16575] ctypes: unions as arguments

Changes by Vinay Sajip : -- nosy: +vinay.sajip ___ Python tracker ___ ___

[issue16575] ctypes: unions as arguments

Eli Bendersky added the comment: I've opened a libffi issue in an attempt to get this fixed upstream: https://github.com/atgreen/libffi/issues/33 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16575

[issue16575] ctypes: unions as arguments

Changes by Eli Bendersky eli...@gmail.com: -- nosy: +theller ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16575 ___ ___ Python-bugs-list mailing

[issue16575] ctypes: unions as arguments

Roundup Robot added the comment: New changeset 0acd9408b6f1 by Eli Bendersky in branch '3.2': Add warning in ctypes documentation for #16575 and #16576 http://hg.python.org/cpython/rev/0acd9408b6f1 New changeset bfc159f8e4b4 by Eli Bendersky in branch '3.3': Add warning in ctypes documentation

[issue16575] ctypes: unions as arguments

Roundup Robot added the comment: New changeset eece32440a52 by Eli Bendersky in branch '2.7': Add warning in ctypes documentation for #16575 and #16576 http://hg.python.org/cpython/rev/eece32440a52 -- ___ Python tracker rep...@bugs.python.org

[issue16575] ctypes: unions as arguments

Eli Bendersky added the comment: A minimal fix would be to update the documentation. A more comprehensive fix would be to tweak ctypes to reject unions and bit-fields when running on non-x86 (does this work for ARM and other non-Intel archs?) An even more comprehensive fix would be to make

[issue16575] ctypes: unions as arguments

Armin Rigo added the comment: See also http://bugs.python.org/issue16576. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16575 ___ ___

[issue16575] ctypes: unions as arguments

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16575 ___

[issue16575] ctypes: unions as arguments

Changes by Meador Inge mead...@gmail.com: -- nosy: +meador.inge ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16575 ___ ___ Python-bugs-list

[issue16575] ctypes: unions as arguments

New submission from Armin Rigo: ctypes pretends to support passing arguments to C functions that are unions (not pointers to unions), but that's a lie. In fact, the underlying libffi does not support it. The attached example misbehaves on Linux x86-64. -- components: ctypes files:

[issue16575] ctypes: unions as arguments

Changes by Alex Gaynor alex.gay...@gmail.com: -- nosy: +alex ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16575 ___ ___ Python-bugs-list mailing

[issue16575] ctypes: unions as arguments

Changes by Armin Rigo ar...@users.sourceforge.net: -- type: - crash ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16575 ___ ___ Python-bugs-list