Roger Serwy added the comment:
@Chris: Thanks for applying the patch. As for IDLE tests, there are no official
tests. Issue15392 calls for the creation of a unit test framework. There are a
few tests in some of IDLE, such as the ones in CallTips. Terry added much
needed improvement for those
Chris Jerdonek added the comment:
FYI, in the 3.2 branch I get 4 failures rather than just the one due to int:
$ ./python.exe Lib/idlelib/CallTips.py
int - expected
'int(x[, base]) - integer'
- but got
'int(x=0) - integer'
list.append - expected
'L.append(object) - None -- append object to
Roundup Robot added the comment:
New changeset 181c170c6270 by Chris Jerdonek in branch '3.2':
Issue #16629: Fix IDLE idlelib.CallTips test. Patch by Roger Serwy.
http://hg.python.org/cpython/rev/181c170c6270
New changeset 5182cc18b7b4 by Chris Jerdonek in branch '3.3':
Issue #16629: Merge
Chris Jerdonek added the comment:
Thanks a lot, Roger!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16629
Chris Jerdonek added the comment:
I created issue 16655 for the three test failures I observed above.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16629
___
Serhiy Storchaka added the comment:
Here is a patch, which adds multiline calltips support.
--
Added file: http://bugs.python.org/file28235/idle_calltips_multiline.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16629
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16629
___
___
Chris Jerdonek added the comment:
Here is a patch, which adds multiline calltips support.
Serhiy, it looks like this issue/patch is just to fix the test and not to add
support. Also, it looks like the test only checks the first line, so that
the second line shouldn't be added to the
Chris Jerdonek added the comment:
Sorry, I see that you changed the logic of get_argspec(). In that case, you
should probably update the docstring of get_argspec() as well as the code
comment I referenced (so that both say which lines are checked rather than the
first line).
--
Serhiy Storchaka added the comment:
Done. Here is an updated patch.
--
Added file: http://bugs.python.org/file28237/idle_calltips_multiline_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16629
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28235/idle_calltips_multiline.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16629
___
Roger Serwy added the comment:
The number of lines in the return value of get_argspec should be limited,
otherwise the calltip window can become too large. For example, many functions
in the numpy project have very long doc strings.
--
___
Python
Chris Jerdonek added the comment:
I would separate the issue of fixing the test (behavior) from adding support
for multi-line tool tips (enhancement). Unless the policy for IDLE is
different, it seems the latter should be limited to 3.4.
--
___
Serhiy Storchaka added the comment:
The number of lines in the return value of get_argspec should be limited,
otherwise the calltip window can become too large.
Calltip limited by first empty line. But I agree, some reasonable hard limit
(say 10 lines) should be.
I would separate the
Serhiy Storchaka added the comment:
Patch updated. Added hard limit (10) for number of calltip lines.
--
Added file: http://bugs.python.org/file28246/idle_calltips_multiline_3.patch
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28237/idle_calltips_multiline_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16629
___
Chris Jerdonek added the comment:
I don't think it was ever a requirement of docstrings that their signature fit
on one line or that they render fully in IDLE. Other built-in functions have
multi-line signatures going back 10+ years (e.g. 32e7d0898eab).
I still think that the rendering of
Serhiy Storchaka added the comment:
I don't think it was ever a requirement of docstrings that their signature
fit on one line or that they render fully in IDLE.
I think this is a requirement of IDLE.
I still think that the rendering of multi-line signatures should be
considered
Chris Jerdonek added the comment:
I created issue 16638 to add support for multi-line signatures.
Then what about this issue?
This issue is to fix the failing test. The test that is failing is to check
that fetch_tip correctly returns the first line of a built-in's docstring and
that it
Roger Serwy added the comment:
So, is the original patch which fixes the original issue OK to apply?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16629
___
Chris Jerdonek added the comment:
Yes, I think so. I should be able to get to it in the next few days unless
someone else beats me to it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16629
New submission from Roger Serwy:
Revision e4598364ea29 changed the docstring for int, causing the CallTips
test to fail in IDLE.
The attached patch fixes the problem.
--
components: IDLE
files: calltips_test_update.patch
keywords: easy, patch
messages: 177063
nosy: serwy, terry.reedy
Serhiy Storchaka added the comment:
Yes, I also noticed this. However, int(x=0) - integer is not enough. The
right calltip should be int(x=0) - integer\nint(x, base=10) - integer.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
23 matches
Mail list logo
