[issue1663329] subprocess/popen close_fds perform poor if SC_OPEN_MAX is hi

Change by STINNER Victor : -- resolution: accepted -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1663329] subprocess/popen close_fds perform poor if SC_OPEN_MAX is hi

sorin sorin.sbar...@gmail.com added the comment: Am I wrong or we should reopen this bug. Try `ulimit -n unlimited` and you'll make python code that does popen practically blocking. -- nosy: +sorin type: - performance ___ Python tracker

[issue1663329] subprocess/popen close_fds perform poor if SC_OPEN_MAX is hi

Georg Brandl added the comment: Reviewed and committed patch as r60097. Thanks for your work! -- assignee: gvanrossum - georg.brandl nosy: +georg.brandl resolution: - accepted status: open - closed _ Tracker [EMAIL PROTECTED]

[issue1663329] subprocess/popen close_fds perform poor if SC_OPEN_MAX is hi

Guido van Rossum added the comment: I'll review this when I have time. Thanks! If you want speedier response, please find someone else among the core developers; or perhaps the bug day on Jan 19 will help. -- assignee: - gvanrossum _ Tracker [EMAIL

[issue1663329] subprocess/popen close_fds perform poor if SC_OPEN_MAX is hi

Mike Klaas added the comment: Updated patch, now with documentation and test. Patch is against 2.6trunk, but probably will apply against 3.0 as well -- components: +Library (Lib) -Interpreter Core versions: +Python 2.6 -Python 2.5 Added file:

[issue1663329] subprocess/popen close_fds perform poor if SC_OPEN_MAX is hi

Mike Klaas added the comment: This problem has also afflicted us. Attached is a patch which adds closerange(fd_low, fd_high) to the posix (and consequently os) module, and modifies subprocess to use it. Patch is against trunk but should work for 2.5maint. I don't really think that this is

[issue1663329] subprocess/popen close_fds perform poor if SC_OPEN_MAX is hi

Mike Klaas added the comment: I see that some spaces crept in to the patch. I can fix that (and perhaps rename the function to start with an underscore) if desired. _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1663329

[issue1663329] subprocess/popen close_fds perform poor if SC_OPEN_MAX is hi

Mike Klaas added the comment: Finally, I did not include any platform-specific optimizations, as I don't have AIX or solaris boxes on which to test them (and they can easily be added later). An order-mag speedup on all *nix platforms is a good start. _

[issue1663329] subprocess/popen close_fds perform poor if SC_OPEN_MAX is hi

Changes by Martin v. Löwis: -- keywords: +patch _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1663329 _ ___ Python-bugs-list mailing list Unsubscribe: