[issue16646] FTP.makeport() loses socket error details

Giampaolo Rodola' added the comment: Ouch! My bad. Thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue16646] FTP.makeport() loses socket error details

Roundup Robot added the comment: New changeset dcefa2c8386b by Giampaolo Rodola' in branch '3.2': Issue 16646 (ftplib): deliberately use intermediate variable after catching exception http://hg.python.org/cpython/rev/dcefa2c8386b New changeset da161499d0c0 by Giampaolo Rodola' in branch '3.3':

[issue16646] FTP.makeport() loses socket error details

Serhiy Storchaka added the comment: I doubt about the committed variant of patch. Note that both my original patch and socket.create_connection() use intermediate variable for catching an exception. This is done deliberately. Example: >>> err = None >>> try: raise ValueError ... except ValueE

[issue16646] FTP.makeport() loses socket error details

Changes by Giampaolo Rodola' : -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue16646] FTP.makeport() loses socket error details

Roundup Robot added the comment: New changeset 6e07be3dfb6b by Giampaolo Rodola' in branch '2.7': Fix issue #16646: ftplib.FTP.makeport() might lose socket error details. (patch by Serhiy Storchaka) http://hg.python.org/cpython/rev/6e07be3dfb6b -- _

[issue16646] FTP.makeport() loses socket error details

Roundup Robot added the comment: New changeset b7419f88c628 by Giampaolo Rodola' in branch '3.2': Fix issue #16646: ftplib.FTP.makeport() might lose socket error details. (patch by Serhiy Storchaka) http://hg.python.org/cpython/rev/b7419f88c628 New changeset b8289a08d720 by Giampaolo Rodola' i

[issue16646] FTP.makeport() loses socket error details

Serhiy Storchaka added the comment: I agree that copying a code from socket.create_connection() is a good idea. Modernizing socket.error to OSError can be done in a separated issue. -- stage: patch review -> commit review ___ Python tracker

[issue16646] FTP.makeport() loses socket error details

Serhiy Storchaka added the comment: socket.error is alias to OSError since 3.3 (PEP 3151). For versions < 3.3 socket.error should be preserved. -- ___ Python tracker ___ ___

[issue16646] FTP.makeport() loses socket error details

Changes by Giampaolo Rodola' : -- assignee: -> giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16646] FTP.makeport() loses socket error details

Giampaolo Rodola' added the comment: Why did you replace socket.error with OSError? I think we should use socket.create_connection() as a guide line: http://hg.python.org/cpython/file/45dfb657b430/Lib/socket.py#l401 A patch is in attachment. -- Added file: http://bugs.python.org/file2834

[issue16646] FTP.makeport() loses socket error details

Changes by Antoine Pitrou : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue16646] FTP.makeport() loses socket error details

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file28263/ftplib_makeport_raise_err.patch ___ Python tracker ___ ___ Python-b

[issue16646] FTP.makeport() loses socket error details

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file28262/ftplib_makeport_raise_err.patch ___ Python tracker ___ ___ Python

[issue16646] FTP.makeport() loses socket error details

New submission from Serhiy Storchaka: In FTP.makeport() a socket error catched and saved but then raised a new error with saved error as argument. Here is a patch which reraises an original error. -- components: Library (Lib) files: ftplib_makeport_raise_err.patch keywords: patch messa