[issue16686] audioop overflow issues

Serhiy Storchaka added the comment: > *All* audioop functions are unsafe regarding unaligned access. Actually this is not true because currently audioop functions work only with bytes (and str, see issue16685) and not with arbitrary memoryview. -- _

[issue16686] audioop overflow issues

Serhiy Storchaka added the comment: I fixed yet one bug in avgpp() and remove my XXX comment. *All* audioop functions are unsafe regarding unaligned access. I'll open a new issue for this. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___

[issue16686] audioop overflow issues

Roundup Robot added the comment: New changeset 6add6ac6a802 by Serhiy Storchaka in branch '2.7': Issue #16686: Fixed a lot of bugs in audioop module. http://hg.python.org/cpython/rev/6add6ac6a802 New changeset 104b17f8316b by Serhiy Storchaka in branch '3.2': Issue #16686: Fixed a lot of bugs in

[issue16686] audioop overflow issues

Serhiy Storchaka added the comment: Thank you Terry. > Is whatever the case in 2.6 only (if so, drop obsolete) or since 2.6. If the > latter, I would rewrite as "this is the case since Python 2.6.". > The addition is not clear to me. Are you implying that something should be > made true for me

[issue16686] audioop overflow issues

Terry J. Reedy added the comment: I do not have the knowledge needed to review the code, but I took a brief look. The three doc patches need a verb to be proper English. "Samples truncated in case of overflow." should be "Samples are truncated in case of overflow." in both places. I think "Sam

[issue16686] audioop overflow issues

Serhiy Storchaka added the comment: Since there is no one who want to review the patch for this dirty buggy module, I will test and review it myself yet once and then commit. -- ___ Python tracker

[issue16686] audioop overflow issues

Serhiy Storchaka added the comment: Can anyone look at the patch? I want fix this issue before 2.7.4 RC released. -- ___ Python tracker ___ __

[issue16686] audioop overflow issues

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16686] audioop overflow issues

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue16686] audioop overflow issues

Changes by Serhiy Storchaka : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue16686] audioop overflow issues

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file28366/audioop.py ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue16686] audioop overflow issues

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file28365/audioop_tests.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue16686] audioop overflow issues

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file28364/audioop.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue16686] audioop overflow issues

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file28397/audioop_2.py ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue16686] audioop overflow issues

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file28396/audioop_2.py ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue16686] audioop overflow issues

Serhiy Storchaka added the comment: I found that the documentation contains a receipt which depends on the fact that bias() wraps around samples. Here is an updated patch. Also some docs changes included. -- Added file: http://bugs.python.org/file28395/audioop_2.patch

[issue16686] audioop overflow issues

Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue16686] audioop overflow issues

Serhiy Storchaka added the comment: 6. reverse() and ratecv() lose 16 lowest bits for 4-bytes data. 7. rms() can returns negative value (-0x8000 instead 0x8000). 8. maxpp() and avgpp() overflow and return absolutely wrong result for large peaks. 9. ratecv() crashes Python on empty inp

[issue16686] audioop overflow issues

Serhiy Storchaka added the comment: 5. max(b'\x00\x00\x00\x80', 4) returns 0 (on little-endian). -- ___ Python tracker ___ ___ Python-

[issue16686] audioop overflow issues

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16686] audioop overflow issues

New submission from Serhiy Storchaka: The audioop module has some issues with an overflow. 1. It uses post-checks for an integer overflow. This means using an undefined behavior. 2. When the result truncated in case of overflow, -maxval used as minimal value. But real minimum value is less (-