R. David Murray rdmur...@bitdance.com added the comment:
OK, here is patch based on the new policy support in 3.3. I have some concern
that the behavior change it introduces might cause some issues, but since it
seems like a reasonable change and is happening at a feature release boundary,
I
R. David Murray rdmur...@bitdance.com added the comment:
Oh, and to be clear on how this addresses the bug report: if you set
'raise_on_defect' to true when you call the parser, then you'll get an
exception when you call msg.get_payload(decode=True).
--
Changes by R. David Murray rdmur...@bitdance.com:
Removed file: http://bugs.python.org/file25737/base64_payload_defects.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1672568
___
R. David Murray rdmur...@bitdance.com added the comment:
Hmm. Thinking about it, though, that might not work if there are other errors
in the message, many of which are more benign. Probably the raise_on_defect
control is a little too coarse.
I've been thinking that we need a way to set the
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 17341b51af4f by R David Murray in branch 'default':
#1672568: email now registers defects for base64 payload format errors.
http://hg.python.org/cpython/rev/17341b51af4f
--
nosy: +python-dev
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d68e30be755e by R David Murray in branch 'default':
News item for #1672568.
http://hg.python.org/cpython/rev/d68e30be755e
--
___
Python tracker rep...@bugs.python.org
R. David Murray rdmur...@bitdance.com added the comment:
Fix committed.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1672568
Changes by R. David Murray rdmur...@bitdance.com:
--
components: +email
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1672568
___
___
R. David Murray rdmur...@bitdance.com added the comment:
I've taken another look at this, and the email module is pretty consistent
about just passing through data if it can't interpret it according to
standards. I think it would lead to a cluttered API if we add support for
being strict and
Mark Lawrence breamore...@yahoo.co.uk added the comment:
I've double checked this and still all tests pass before patching message.py.
Could somebody else please pick this one up, thanks.
--
___
Python tracker rep...@bugs.python.org
Mark Lawrence breamore...@yahoo.co.uk added the comment:
To me a bug is a bug is a bug, but I'm sure there are different opinions so
feel free to swap this back to feature request if you think that fits. I'll
try and have a crack at this tomorrow.
--
nosy: +BreamoreBoy
type: feature
R. David Murray rdmur...@bitdance.com added the comment:
No, it's not a bug if it is working as documented. (Well, it might be a design
bug, but fixes to those are called feature requests :)
We're planning on addressing this is email6, by the way.
I'm OK with trying to get this into 3.2, but
Changes by Barry A. Warsaw ba...@python.org:
--
assignee: barry - r.david.murray
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1672568
___
Renaud Blanch rndbl...@gmail.com added the comment:
looks very good to me.
thanks daniel for your work
renaud
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1672568
___
Daniel Diniz aja...@gmail.com added the comment:
Renaud,
Here's your patch with a test case against trunk.
--
stage: test needed - patch review
Added file: http://bugs.python.org/file13967/noisy_get_payload.diff
___
Python tracker
Daniel Diniz aja...@gmail.com added the comment:
Looks good to me, adding tests and docs could be a nice Bug Day task.
--
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1672568
Renaud Blanch rndbl...@gmail.com added the comment:
good idea, why not something like sketched in the attached patch?
it does not break any existing code, while providing a way for new users
to have a chance to get the decoding errors.
of course, the doc should be updated accordingly, and tests
Daniel Diniz aja...@gmail.com added the comment:
Hmm, ISTM that a change that breaks existing code that relies on
documented behavior has a negligible chance of being accepted.
However, I agree that the current behavior isn't developer-friendly. I
think adding an alternative behavior to
Renaud Blanch rndbl...@gmail.com added the comment:
Daniel: i can't remember the exact scenario (i filled this bug 2 years
ago !)
after having a look back at email.message.Message.get_payload, i
remember the problem: the decoding errors are silented by the method and
you have no way to know if
Daniel Diniz aja...@gmail.com added the comment:
Renaud: providing a test script would help us here.
--
nosy: +ajaksu2
stage: - test needed
type: - behavior
versions: +Python 2.6, Python 3.0
___
Python tracker rep...@bugs.python.org
20 matches
Mail list logo
