Éric Araujo mer...@netwok.org added the comment:
Doc patch to fix a reST error and tweak a few things.
--
Added file: http://bugs.python.org/file23448/urllib.request-doc.diff
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Attached patch changes one occurrence of ugly whitespace, changes “not x == y”
to “x != y” and “not x in y” to “x not in y”. Senthil, feel free to apply
none, some or all of these minor cleanups.
--
Added file:
Senthil Kumaran sent...@uthcode.com added the comment:
Hi Eric,
The changes suggested in the patch are good for readability, I
shall include them all. Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 0a0aafaa9bf5 by Senthil Kumaran in branch 'default':
Fix closes issue 1673007 urllib.request to support HEAD requests with a new
method arg.
http://hg.python.org/cpython/rev/0a0aafaa9bf5
--
nosy:
Senthil Kumaran sent...@uthcode.com added the comment:
I have committed the patch accomodating the doc review comments which Ezio had
mentioned. At the moment, the current way seems to be most backwards compatible
one and did not want to delay it. Let's hope we get some feedback on this
Patrick Westerhoff patrickwesterh...@gmail.com added the comment:
Senthil, I highly disagree with what you said:
The next problem comes when a user has specified both data and method=GET.
This becomes an invalid scenario, but a decision has been to taken as what
should be given preference?
Senthil Kumaran sent...@uthcode.com added the comment:
Patrick,
Lots of valid points. I had not looked at the RFC spec when I mentioned about
data over request (GET) method, but was trying to derive the current
functionality of module (so that users can have a seamless experience) with
Ezio Melotti ezio.melo...@gmail.com added the comment:
Attached an updated patch that addresses the comments of Éric in the review and
adds an entry to the whatsnew.
--
assignee: orsenthil - ezio.melotti
keywords: +needs review
nosy: -BreamoreBoy
stage: patch review - commit review
Senthil Kumaran sent...@uthcode.com added the comment:
Hi Ezio, I had probably overlooked this one. But It's a very interesting one
for me. Do you mind if I commit it ?
On Oct 10, 2011 7:20 PM, Ezio Melotti rep...@bugs.python.org wrote:
Ezio Melotti ezio.melo...@gmail.com added the comment:
Éric Araujo mer...@netwok.org added the comment:
I made some more comments.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: ezio.melotti - orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
We have discussed the API a bit on IRC and these are the outcomes:
1) should method always have priority or should 'POST' always be used whenever
data is passed?
2) if the method is e.g. 'GET' and data is passed, should an error be raised?
Senthil Kumaran sent...@uthcode.com added the comment:
Our discussion stemmed from this point. If you look at the change proposed,
Request class is taking a new parameter by name 'method' and it is initialized
to None:
class Request:
def __init__(self, url, data=None, headers={},
-
Changes by Patrick Westerhoff patrickwesterh...@gmail.com:
--
nosy: +poke
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
___
Changes by Brian Curtin br...@python.org:
--
nosy: +brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
___
Python-bugs-list
Denver Coneybeare denver.coneybe...@gmail.com added the comment:
I decided to take a look at this old, forgotten issue and propose an updated
patch. I like the submitter's idea that urllib.Request.__init__() should take
a method parameter to override the return value of get_method(). I've
Changes by Santoso Wijaya santoso.wij...@gmail.com:
--
nosy: +santa4nt
versions: +Python 3.3 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
ipatrol ipatrol6...@yahoo.com added the comment:
Can this be somehow implemented as a bugfix patch as well on other versions?
--
nosy: +ipatrol
versions: +Python 2.7, Python 3.1
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Only stable (2.7 and 3.1) and development versions (3.2) get bug fixes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
Antoine Pitrou pit...@free.fr added the comment:
New features can only go in 3.2. From a quick look, the patch looks ok.
--
nosy: +pitrou
versions: -Python 2.7, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
Changes by Jack Diederich jackd...@gmail.com:
--
nosy: +jackdied
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
___
Python-bugs-list
David Stanek dsta...@dstanek.com added the comment:
I have attached a patch to add support for HEAD, PUT and DELETE methods. The
code review is available here: http://codereview.appspot.com/1696061.
I have started working on another patch that validates that the method is
properly set. For
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Seems to be +1 for HEAD, -1 for history, keyword says easy so should be
feasable for 3.2. :)
--
nosy: +BreamoreBoy
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
Senthil Kumaran orsent...@gmail.com added the comment:
Here is a discussion and explanation from the submitter on what is meant
by history of requests.
http://mail.python.org/pipermail/python-dev/2007-March/072069.html
--
___
Python tracker
Senthil Kumaran orsent...@gmail.com added the comment:
Having a HEAD request for urllib2 might be a good idea. I shall use this
patch to add the functionality.
But, having a history support in the urllib2 module is not a good idea
IMO. It is best left to the clients which might use urllib2.
Ezio Melotti ezio.melo...@gmail.com added the comment:
+1 for HEAD
--
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
Éric Araujo mer...@netwok.org added the comment:
If you know you want an HEAD request, it means you already know it
will be an HTTP request, so why not directly use httplib or httplib2
instead of urllib?
Aside: s/sended/sent/
Cheers
--
nosy: +Merwok
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
___
Changes by Senthil Kumaran orsent...@gmail.com:
--
assignee: - orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
___
Changes by Daniel Diniz aja...@gmail.com:
--
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
___
Python-bugs-list
Daniel Diniz aja...@gmail.com added the comment:
Patch has tests too, might need updating.
:)
--
nosy: +ajaksu2, orsenthil
stage: - patch review
type: - feature request
versions: +Python 2.7 -Python 2.6
___
Python tracker rep...@bugs.python.org
Changes by Daniel Diniz aja...@gmail.com:
--
nosy: +jjlee
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
___
Python-bugs-list mailing
32 matches
Mail list logo
