[issue16802] fileno argument to socket.socket() undocumented

2015-10-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset f4606117d571 by Berker Peksag in branch '3.4': Issue #16802: Document fileno parameter of socket.socket() https://hg.python.org/cpython/rev/f4606117d571 New changeset 1d14675c6050 by Berker Peksag in branch '3.5': Issue #16802: Document fileno

[issue16802] fileno argument to socket.socket() undocumented

2015-10-07 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker

[issue16802] fileno argument to socket.socket() undocumented

2015-10-02 Thread Bar Harel
Bar Harel added the comment: Here you go. -- nosy: +bar.harel Added file: http://bugs.python.org/file40656/Issue16802_rev2.patch ___ Python tracker ___

[issue16802] fileno argument to socket.socket() undocumented

2015-10-02 Thread Guido van Rossum
Guido van Rossum added the comment: Patch looks good. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue16802] fileno argument to socket.socket() undocumented

2014-11-14 Thread Petri Lehtinen
Petri Lehtinen added the comment: To me, there's also a valid use case on Unix; A parent process forks and execs, wanting to share a socket to the executed child process. The best way for the child to create a socket object is to use the fileno parameter of socket.socket(). -- nosy:

[issue16802] fileno argument to socket.socket() undocumented

2014-10-17 Thread Berker Peksag
Berker Peksag added the comment: The actual signature is now socket.socket(family=AF_INET, type=SOCK_STREAM, proto=0, fileno=None) but, the fileno argument still needs to be documented. -- nosy: +berker.peksag stage: needs patch - patch review versions: +Python 3.5 -Python 3.2,

[issue16802] fileno argument to socket.socket() undocumented

2013-02-23 Thread Henrik Heimbuerger
Henrik Heimbuerger added the comment: Here's a suggestion for a documentation addition. Comments on tone and content are welcome, and I'm willing to update it and submit modified patch files. This adds the following note: If a file descriptor *fileno* is specified, the other arguments

[issue16802] fileno argument to socket.socket() undocumented

2013-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- keywords: +easy stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16802 ___

[issue16802] fileno argument to socket.socket() undocumented

2012-12-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The fileno parameter was added in the changeset 8e062e572ea4. It was mentioned in comments at the top of Modules/socketmodule.c, but not in the documentation or docstrings (nor for _socket.socket, nor for socket.socket). -- assignee: - docs@python

[issue16802] fileno argument to socket.socket() undocumented

2012-12-31 Thread Antoine Pitrou
Antoine Pitrou added the comment: The fileno argument looks like an implementation detail to me. -- nosy: +gvanrossum ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16802 ___

[issue16802] fileno argument to socket.socket() undocumented

2012-12-31 Thread Richard Oudkerk
Richard Oudkerk added the comment: The fileno argument looks like an implementation detail to me. It has at least one potential use. On Windows socket.detach() returns a socket handle but there is no documented way to close it -- os.close() will not work. The only way to close it that I

[issue16802] fileno argument to socket.socket() undocumented

2012-12-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It has at least one potential use. On Windows socket.detach() returns a socket handle but there is no documented way to close it -- os.close() will not work. The only way to close it that I can see (without resorting to ctypes) is with something like

[issue16802] fileno argument to socket.socket() undocumented

2012-12-31 Thread Richard Oudkerk
Richard Oudkerk added the comment: There is an alternative (documented) interface: socket.fromfd(handle, socket.AF_INET, socket.SOCK_STREAM).close() socket.fromfd() duplicates the handle, so that does not close the original handle. -- ___

[issue16802] fileno argument to socket.socket() undocumented

2012-12-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Indeed. In any case, if this idiom is widely used, we can't hide this parameter and should document it (and perhaps document this idiom). If BDFL not want this parameter was made public, he would not have added it as an keyword argument. However, may be to

[issue16802] fileno argument to socket.socket() undocumented

2012-12-31 Thread Guido van Rossum
Guido van Rossum added the comment: I recommend documenting it. On Monday, December 31, 2012, Serhiy Storchaka wrote: Serhiy Storchaka added the comment: Indeed. In any case, if this idiom is widely used, we can't hide this parameter and should document it (and perhaps document this

[issue16802] fileno argument to socket.socket() undocumented

2012-12-30 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16802 ___ ___

[issue16802] fileno argument to socket.socket() undocumented

2012-12-28 Thread Richard Oudkerk
New submission from Richard Oudkerk: The actual signature is socket.socket(family=AF_INET, type=SOCK_STREAM, proto=0, fileno=None) but the documented signature is socket.socket([family[, type[, proto]]]) Should the fileno argument be documented or is it considered an implementation

[issue16802] fileno argument to socket.socket() undocumented

2012-12-28 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16802 ___ ___