Ezio Melotti added the comment:
Attached a new patch.
--
Added file: http://bugs.python.org/file28562/issue16835-3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16835
___
Zachary Ware added the comment:
Looks good to me :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16835
___
___
Python-bugs-list mailing list
Brett Cannon added the comment:
LGTM as well. Feel free to commit it, Ezio, or assign to me and I will commit
it later (probably this weekend).
--
assignee: - eric.araujo
nosy: +eric.araujo
stage: patch review - commit review
___
Python tracker
Ezio Melotti added the comment:
Done in http://hg.python.org/peps/rev/3740f42d3b94, thanks for the reviews!
--
assignee: eric.araujo - ezio.melotti
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python
Zachary Ware added the comment:
Thanks for the review, new patch attached.
You're quite welcome. Is there anything I've missed in the process of
reviewing itself? This is the first time I've reviewed a patch here...
I did miss another nit in the prose, though; the tests methods in the
Philip Jenvey added the comment:
Hey Ezio, you forgot to attach the patch
--
nosy: +pjenvey
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16835
___
Ezio Melotti added the comment:
That would explain why no one was reviewing it :)
--
keywords: +patch
Added file: http://bugs.python.org/file28533/issue16835.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16835
Zachary Ware added the comment:
A few minor grammatical and style nits in the prose added at the end of the
diff:
+The test module defines a base class with the tests methods that access the
+``heapq`` module through a ``self.heapq`` class attribute, and two subclasses
+that set this
Ezio Melotti added the comment:
Thanks for the review, new patch attached.
This should either have another newline inbetween or be reflowed.
Either one paragraph or two makes sense to me, but I can't tell which
way you actually meant
I meant one and half :)
I guess in HTML that would have
Changes by Ezio Melotti ezio.melo...@gmail.com:
Removed file: http://bugs.python.org/file28538/issue16835-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16835
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
Added file: http://bugs.python.org/file28539/issue16835-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16835
___
New submission from Brett Cannon:
Don't have the base tests inherit from TestCase else they will be discovered by
unittest and run even though they are not fully defined.
See http://bugs.python.org/issue16748 as the trigger for this issue.
--
messages: 178748
nosy: brett.cannon
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: - ezio.melotti
components: +Documentation
nosy: +ezio.melotti
stage: - needs patch
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16835
Ezio Melotti added the comment:
Here's a patch:
1) the base class doesn't inherit from TestCase anymore -- the subclasses do;
2) added a skipUnless() decorator on the C subclass;
3) used the modern if __name__ == '__main__': unittest.main() idiom;
4) renamed the AcceleratedExampleTest to
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16835
___
___
15 matches
Mail list logo
