Benjamin Peterson [EMAIL PROTECTED] added the comment:
I'm ok with this patch.
--
keywords: -needs review
nosy: +benjamin.peterson
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1688
___
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
Committed r66545.
--
resolution: - fixed
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1688
___
Vlastimil Brom [EMAIL PROTECTED] added the comment:
While I am not sure about the status of this somewhat older issue, I
just wanted to mention, that the behaviour remains the same in Python
3.0rc1 (XPh SP3, Czech)
Python 3.0rc1 (r30rc1:66507, Sep 18 2008, 14:47:08) [MSC v.1500 32 bit
Martin v. Löwis [EMAIL PROTECTED] added the comment:
Amaury, what further review of the patch do you desire? I had already
commented that I consider the patch correct, except that it might use
stdout_encoding instead.
Also, I wouldn't consider this a release blocker. It is somewhat
annoying
Guido van Rossum [EMAIL PROTECTED] added the comment:
Given MvL's review, assuming it fixes the Czech problem, I'm all for
applying it.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1688
___
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
Here is a new version of the patch: the PyString* functions were renamed
to PyBytes*, and it now uses stdout_encoding.
About the release blocker status: I agree it is not so important, I
just wanted to express my it's been here for long,
Martin v. Löwis added the comment:
Isn't it enough to encode the prompt with the console encoding, instead
of letting the default utf-8 conversion? This patch corrects the issue
on Windows:
Sounds right. Technically, you should be using the stdout encoding, but
I don't think it should ever
Amaury Forgeot d'Arc added the comment:
Isn't it enough to encode the prompt with the console encoding, instead
of letting the default utf-8 conversion? This patch corrects the issue
on Windows:
Index: ../Python/bltinmodule.c
===
Guido van Rossum added the comment:
Cool.
I suspect Unix will also require a customized version to be used in case
GNU readline isn't present.
And I wouldn't be surprised if GNU readline itself doesn't handle UTF-8
properly either!
__
Tracker [EMAIL PROTECTED]
Changes by Amaury Forgeot d'Arc:
--
nosy: +amaury.forgeotdarc
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1688
__
___
Python-bugs-list mailing list
Unsubscribe:
Vlastimil Brom added the comment:
First sorry about a delayed response, but moreover, I fear, preparing a
patch would be far beyond my programming competence; sorry about that.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1688
Martin v. Löwis added the comment:
Would you like to work on a patch?
--
nosy: +loewis
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1688
__
___
Python-bugs-list
12 matches
Mail list logo
