R. David Murray rdmur...@bitdance.com added the comment:
I am indeed going to close this. The patch isn't complete, since there's the
line ending issue Antoine pointed out, which implies that there are also some
missing tests.
I doubt that linecache performance is something that affects
umaxx m...@umaxx.net added the comment:
@BreamoreBoy: what do you man by taking this forward?
The patch is there. Since three years now, no one else seems to be interested.
I personally do not have any interest in this anymore as I just do not use
Python for this stuff anymore since a long
Mark Lawrence breamore...@yahoo.co.uk added the comment:
@umaxx are you interested in taking this forward?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1708
___
Antoine Pitrou pit...@free.fr added the comment:
Looking at the patch, the recorded seek points will probably be wrong if
some newlines were translated (e.g. '\r\n' - '\n') when reading the file.
I'm also not sure not what the use case for very big files is. linecache
is primarily used for
umaxx um...@oleco.net added the comment:
Looking at the patch, the recorded seek points will probably be wrong if
some newlines were translated (e.g. '\r\n' - '\n') when reading the file.
ack, this could be a problem.
I'm also not sure not what the use case for very big files is.
this is
Changes by Guido van Rossum gu...@python.org:
--
assignee: gvanrossum -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1708
___
___
Changes by Guido van Rossum gu...@python.org:
--
nosy: -gvanrossum
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1708
___
___
Python-bugs-list
Guido van Rossum added the comment:
I'll look at this when I have time. If you find someone else interested
in reviewing, please give them the patch!
--
assignee: - gvanrossum
keywords: +patch
nosy: +gvanrossum
priority: - low
__
Tracker [EMAIL
New submission from umaxx:
here comes a simple patch for linecache core module, which does the
following:
- remove double comment
- instead of adding all lines with readlines() to the cache, just add
seek points for every line
- return lines from cached seek-points instead directly from
