Boštjan Mejak bostjan.me...@gmail.com added the comment:
Please fix this patch to raise BadZipFile instead of BadZipfile. See
http://docs.python.org/dev/library/zipfile.html?highlight=zipfile#zipfile.BadZipfile.
The use of the class name BadZipfile is deprecated. The class name BadZipFile
is
Georg Brandl ge...@python.org added the comment:
Not sure what you're referring to, all occurrences of BadZipfile (except for
its definition and its documentation) have been removed in py3k.
--
___
Python tracker rep...@bugs.python.org
Georg Brandl ge...@python.org added the comment:
Okay, applied as r85455.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1710703
___
Changes by Alan McIntyre alan.mcint...@gmail.com:
Removed file: http://bugs.python.org/file9144/empty-zipfile.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1710703
___
Alan McIntyre alan.mcint...@gmail.com added the comment:
My apologies if Georg was waiting on me to say, Yes. :-)
I've attached an updated patch that has the NEWS/doc changes Antoine mentioned.
I also just checked that the tests still pass on Linux against the current
trunk, and that the
Changes by Alan McIntyre alan.mcint...@gmail.com:
Removed file: http://bugs.python.org/file18534/zipfile_empty2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1710703
___
Mark Lawrence breamore...@yahoo.co.uk added the comment:
I don't think the latest patch has been committed, could someone wave their
magic wand please :)
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
Two nits:
- bug fixes shouldn't have a versionadded or versionchanged entry (it's
only for new features)
- Misc/NEWS should be in antichronological order
--
nosy: +pitrou
___
Python tracker
Georg Brandl ge...@python.org added the comment:
Agreed with Antoine. Do you want to commit?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1710703
___
Alan McIntyre alan.mcint...@gmail.com added the comment:
Apparenty _EndRecData64 needed the same kind of check that _EndRecData has when
trying to seek to the end-of-archive record. So I added that, and everything
seems to work correctly now. All tests pass on my 64-bit Linux box (including
Alan McIntyre alan.mcint...@gmail.com added the comment:
Sure thing; I'll see if I can have a look within the next week or so.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1710703
___
Georg Brandl ge...@python.org added the comment:
Alan, I've updated the patch for current 3.2 trunk, see attached, but the new
test now fails. Can you find out why?
--
nosy: +georg.brandl
versions: +Python 3.2 -Python 2.7
Added file: http://bugs.python.org/file18257/zipfile_empty.diff
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
keywords: +patch
stage: - test needed
type: - behavior
versions: +Python 2.7 -Python 2.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1710703
Alan McIntyre added the comment:
Here's a quick patch that covers the issues mentioned in my post from
2007-05-09.
Added file: http://bugs.python.org/file9144/empty-zipfile.diff
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1710703
14 matches
Mail list logo
