Ned Deily added the comment:
turtle_demo_v3.patch looks good to me. I have satisfied myself that the
AppleScript works OK with a non-English system. And, while it is a bit of a
kludge for OS X and assuming the rest of the change works OK on Windows and
Linux, I would recommend to Terry that
Ronald Oussoren added the comment:
I don't have a better solution for this, although I'd slightly prefer to add a
hack to the turtledemo main function to force itself to the foreground on
startup. That way the hack also works when the user starts the script in a
Terminal window.
--
Lita Cho added the comment:
Thanks for the input Ronald! How would I go about forcing the turtledemo to be
in the foreground? Do I just need to call 'fg' on the subprocess? I've been
Googling and couldn't find anything obvious.
--
___
Python
Ned Deily added the comment:
Ronald:
I'd slightly prefer to add a hack to the turtledemo main function to force
itself to the foreground on startup. That way the hack also works when the
user starts the script in a Terminal window.
That's exactly what the proposed patch does. The
Terry J. Reedy added the comment:
I agree with skipping 2.7. The current patch is based on importing turtledemo,
while on 2.7, turtleDemo.py is in Demo/turtle/ and cannot be imported. It could
run with execfile, but the viewer will only run if /turtle is the current
directory. On Windows,
Ned Deily added the comment:
If the activate code is moved to macosxSupport.activate(), does the
following work in EditorWindow.open_turtle_demo?
cmd = [sys.executable, '-c',
'from idlelib.macosxSupport import activate as A; A()\n'
'from turtledemo.__main__ import main; main()']
Does the
Roundup Robot added the comment:
New changeset 04dd26ca02f4 by Terry Jan Reedy in branch '3.4':
Issue #17172: Add the ability to run turtledemo from Idle.
http://hg.python.org/cpython/rev/04dd26ca02f4
--
nosy: +python-dev
___
Python tracker
Terry J. Reedy added the comment:
I would have made the turtledemo fix a separate issue. Given the combined
patch, I will just make separate NEWS entries (which I am working on now).
I expect there to be other new entries for Shell/Run, and will move when that
is true.
--
Changes by Terry J. Reedy tjre...@udel.edu:
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
Roundup Robot added the comment:
New changeset e344539cda11 by Terry Jan Reedy in branch '3.4':
Issue #17172: add NEWS
http://hg.python.org/cpython/rev/e344539cda11
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
Changes by Terry J. Reedy tjre...@udel.edu:
--
assignee: ezio.melotti - terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
___
Ned Deily added the comment:
Here are some review comments on turtle_demo_v2.patch.
First, the subprocess call to start turtledemo may work ok in your build
directory but it will not work in general. Using the standard idiom for
invoking a new process running the current instance of python,
Lita Cho added the comment:
I wasn't aware of make patchcheck. I will run this script when submitting
patches in the future. Thanks, Ned!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
Lita Cho added the comment:
I've updated this patch to include the changes Ned mentioned. I am waiting to
hear from Ronald if he has a better solution about dealing with the focus
problem with the keyboard and mouse.
--
Added file: http://bugs.python.org/file36121/turtle_demo_v3.patch
Lita Cho added the comment:
Here is a new patch where it checks to see if turtledemo exists first before
loading it onto the bindings.
--
Added file: http://bugs.python.org/file36081/turtle_demo_v2.patch
___
Python tracker rep...@bugs.python.org
Lita Cho added the comment:
I personally think it would be better to check to see if the turtledemo exists
during startup, and if so, add the menu entry. Otherwise, don't add it when
loading up IDLE.
--
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
In 2.7, turtledemo is in pythondir/Demo/turtle when those directories are
present. They are not currently installed by the 2.7 Windows installer, but
this could be requested (of Steve Dower) on another issue. A 2.7 patch would be
slightly tricker as it would
Lita Cho added the comment:
Hi Terry, can we close this issue? Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
___
Lita Cho added the comment:
Okay! That makes sense. Any bugs that Turtle has, people will assume IDLE has
them too if they launch it from IDLE.
I will take on #21597, and work on that instead. Thanks!
--
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
0. My general interest is in running external programs and in particular, for
this issue, python modules intended to be run as main. Some other scripts I
would like to be able to easily launch from Idle include
List/test.test_idle.py,
Terry J. Reedy added the comment:
I withdraw my suggestion that turtledemo get anything added just for moving
code to Idle. What is does need is the ability to widen the code pane so one
can more easily read or cut (by normal means). See #21597.
One of my concerns about putting turtledemo on
Lita Cho added the comment:
I am currently in the process of editing this patch such that the Turtle Demo
launches from the Help Menu and spawns a separate process.
However, I am deciding whether if the separate process should be asynchronous
or not. Currently, I have it working with the
Raymond Hettinger added the comment:
the IDLE window is hanging
Check to make sure it is actually hung. The event-loop can make it look hung
but it is actually just waiting for an event. An IDLE restart suffices to kill
it sometimes.
--
___
Lita Cho added the comment:
Okay, maybe hanging is not the right word. The IDLE window becomes busy since
it spawned off the Turtle demo subprocess, and it is waiting for the subprocess
to finish. After I close the Turtle window, it returns back to normal.
I was wondering if the Turtle Demo
Lita Cho added the comment:
I currently have a patch where the Turtle Demo now shows up in the Help menu
rather than in File menu.
I also have it such that Turtle is now launched as a separate process rather
than within the IDLE process. Currently, the commend is calling ./python.exe so
it
Terry J. Reedy added the comment:
I think a patch should reuse the run module function that Idle already has. No
need to re-invent something. I will say more tomorrow after sleeping.
--
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
My thoughts on this. Overall, +.something (and increasing as I look at it more
;-).
I am opposed to adding this to the relatively long file menu. It has nothing to
do with manipulating or editing files. If it is to go in, please put it on the
help menu, at
Lita Cho added the comment:
I did not know that NEWS items should not be edited unless it is about to be
committed. The previous comments suggested to put it in. Thank you for the
feedback.
I can move the Turtle Demp into the Help Menu rather than the File menu. I
agree that it seems out of
Lita Cho added the comment:
I tested the patch and it looks correct upon inspection. It looks like it
applies cleanly and a straight forward solution.
I made a slight change so that when the Demo exits, it has a better message. I
also added the change to the NEWS.txt file.
I also ran the
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
___
Raymond Hettinger added the comment:
Ezio, would you like to take it from here?
--
assignee: - ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
Ezio Melotti added the comment:
I left a comment in rietveld.
I hope the File menu is the right place for this.
I think that's the best place where to put it.
I had to move the code in Lib/turtledemo.py after if __name__ ==... into
main().
Why?
Should this be added to
Ramchandra Apte added the comment:
Because turtledemo doesn't have a main() function. I moved the code under 'if
__name__ == __main__' into a main() function.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
Ramchandra Apte added the comment:
Attached is a patch. I hope the File menu is the right place for this. I had to
move the code in Lib/turtledemo.py after if __name__ ==... into main().
--
___
Python tracker rep...@bugs.python.org
Changes by Ramchandra Apte maniandra...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file29048/issue.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
Ramchandra Apte added the comment:
Should this be added to Lib/idlelib/NEWS.txt ?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
___
Ramchandra Apte added the comment:
Will attach patch. Coincidentally I'm am a younger programmer.
--
nosy: +ramchandra.apte
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
Ramchandra Apte added the comment:
Should be ... I'm a younger...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
___
Python-bugs-list
New submission from Raymond Hettinger:
The turtledemo is an on-ramp for younger programmers and we should make it easy
to launch.
--
components: IDLE
keywords: easy
messages: 181757
nosy: rhettinger
priority: normal
severity: normal
stage: needs patch
status: open
title: Add turtledemo
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +kbk
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
___
Python-bugs-list mailing list
Changes by Senthil Kumaran sent...@uthcode.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
___
___
Python-bugs-list
41 matches
Mail list logo
