[issue17394] Add slicing support to collections.deque

Raymond Hettinger added the comment: > If no, you can just close it. Yes, I would rather close this than apply this patch. -- resolution: -> rejected status: open -> closed ___ Python tracker

[issue17394] Add slicing support to collections.deque

Serhiy Storchaka added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17394] Add slicing support to collections.deque

Serhiy Storchaka added the comment: Raymond, do you still have an interest in this issue? If no, you can just close it. -- ___ Python tracker ___

[issue17394] Add slicing support to collections.deque

Serhiy Storchaka added the comment: Raymond, do you have a time to make a review? -- ___ Python tracker ___

[issue17394] Add slicing support to collections.deque

Serhiy Storchaka added the comment: The output now is a deque. -- Added file: http://bugs.python.org/file42082/deque_slices_3.patch ___ Python tracker

[issue17394] Add slicing support to collections.deque

Serhiy Storchaka added the comment: Since the patch is so complex, I suggest to split it on parts, and review and commit them separately: 1) Refactoring. Extract common code to macros and utility functions. These macros can be used for more efficient implementing insert() and __del__. 2) Add

[issue17394] Add slicing support to collections.deque

Raymond Hettinger added the comment: I'm already underway for the review. The "refactoring" part is making is more difficult. We just need slicing support to be added. Yes, I do want slice assignment and deletion. The output should be a deque, not a list. --

[issue17394] Add slicing support to collections.deque

Josh Rosenberg added the comment: It seems odd to have a slice of a deque return a list. Are there any other examples of non-buffer protocol objects behaving like this in the standard library/built-ins? Only examples I can come up with are mmap objects and ctypes arrays (which are making raw

[issue17394] Add slicing support to collections.deque

Raymond Hettinger added the comment: Returning a deque is preferred. For this stage, I just want to review the code and make sure it algorithmically correct (slicing is complicated and has a lot of cases). -- ___ Python tracker

[issue17394] Add slicing support to collections.deque

Raymond Hettinger added the comment: Thank you for doing this work. -- ___ Python tracker ___ ___

[issue17394] Add slicing support to collections.deque

Serhiy Storchaka added the comment: Synchronized with current sources and added mandatory now braces. -- Added file: http://bugs.python.org/file41723/deque_slices_2.patch ___ Python tracker

[issue17394] Add slicing support to collections.deque

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file41495/deque_slices.patch ___ Python tracker ___

[issue17394] Add slicing support to collections.deque

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file41506/deque_slices.patch ___ Python tracker ___

[issue17394] Add slicing support to collections.deque

Serhiy Storchaka added the comment: Proposed patch implements getting, deleting and setting slices in deque. Getting a slice returns a list, but this can be changed if needed. -- assignee: -> rhettinger keywords: +patch stage: needs patch -> patch review versions: +Python 3.6 -Python

[issue17394] Add slicing support to collections.deque

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file41491/deque_slices.patch ___ Python tracker ___

[issue17394] Add slicing support to collections.deque

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file41495/deque_slices.patch ___ Python tracker ___

[issue17394] Add slicing support to collections.deque

Larry Hastings added the comment: For the record, Raymond asked for permission to check this in (a new feature) for 3.5 beta 2, as he won't have time to finish it before beta 1. As 3.5 release manager I've given him permission. Go Raymond! -- ___

[issue17394] Add slicing support to collections.deque

Changes by Larry Hastings la...@hastings.org: -- nosy: +larry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17394 ___ ___ Python-bugs-list mailing

[issue17394] Add slicing support to collections.deque

Changes by Yury Selivanov yselivanov...@gmail.com: -- versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17394 ___

[issue17394] Add slicing support to collections.deque

Serhiy Storchaka added the comment: What type should be a result of slicing? List, tuple, deque, other? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17394 ___

[issue17394] Add slicing support to collections.deque

Raymond Hettinger added the comment: The slicing support can be implemented using just rotates, appends, and pops. -- assignee: rhettinger - nosy: +serhiy.storchaka priority: low - normal stage: - needs patch type: - enhancement ___ Python tracker

[issue17394] Add slicing support to collections.deque

New submission from Raymond Hettinger: Once added, use it in threading.Condition(). -- assignee: rhettinger components: Library (Lib) messages: 183918 nosy: rhettinger priority: low severity: normal status: open title: Add slicing support to collections.deque versions: Python 3.4

[issue17394] Add slicing support to collections.deque

Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17394 ___ ___ Python-bugs-list mailing list