Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: -BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1739648
___
___
Serhiy Storchaka added the comment:
I added comments in Rietveld.
--
components: +Tests
versions: +Python 3.3, Python 3.4 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1739648
Serhiy Storchaka storch...@gmail.com added the comment:
I'm not sure about new tests, but the changes in the docstring and old tests
look necessary.
--
Added file: http://bugs.python.org/file25402/testzip-patch4.patch
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1739648
___
___
Alan McIntyre alan.mcint...@gmail.com added the comment:
I'd be glad to do some code reviews or something in exchange for the time of
somebody with commit rights. :-) If anybody is interested in getting this
change committed, please let me know and I'll check that the patch is still
valid.
Alan McIntyre alan.mcint...@gmail.com added the comment:
I re-checked testzip-patch3.diff since some time has passed since I last
commented on it, and it still seems to work ok (the small test_zipfile.py block
failed to apply, but that's easy enough to do manually). Passes full test run,
Alan McIntyre alan.mcint...@gmail.com added the comment:
Here's an updated patch against the py3k trunk (testzip-patch3.diff) that
passes all tests (including test_zipfile64) on Linux on a 64-bit machine.
I can backport this to 2.x, but I'll wait until somebody indicates a need for
it before
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1739648
___
___
Python-bugs-list mailing
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Tried the patch against 2.7 and got RuntimeError: Attempt to read ZIP archive
that was already closed for TestsWithSourceFile test_deflated and test_stored.
The patch needs updating for py3k.
--
nosy: +BreamoreBoy
stage: unit
Alan McIntyre alan.mcint...@gmail.com added the comment:
Ok, I'll see if I can update that in the next week or so.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1739648
___
Alan McIntyre alan.mcint...@gmail.com added the comment:
Attached is a patch that makes the zipfile module check the result of
testzip when run as __main__ as well as in test_zipfile.py, and adds
some tests in test_zipfile64.py. The changes to test_zipfile64.py
increased its runtime from ~671
Changes by Daniel Diniz aja...@gmail.com:
--
stage: - test needed
type: - resource usage
versions: +Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1739648
___
Alan McIntyre alan.mcint...@gmail.com added the comment:
It would appear that the change to testzip has already been made:
http://mail.python.org/pipermail/python-checkins/2008-August/072892.html
http://mail.python.org/pipermail/python-3000-checkins/2008-August/004310.html
I can add some
Alan McIntyre added the comment:
This sort of change definitely needs to be made to avoid reading huge
files into memory for testzip(). I've attached a modified patch as
zipfile_testzip_amcintyre.diff; it didn't seem appropriate to have a
module-level variable for the size of the test read, and
Grzegorz Adam Hankiewicz
added the comment:
Any progress report on this issue, please?
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1739648
15 matches
Mail list logo
