Roundup Robot added the comment:
New changeset d18df4c90515 by R David Murray in branch '3.3':
#17413: make sure settrace funcs get passed exception instances for 'value'.
http://hg.python.org/cpython/rev/d18df4c90515
New changeset 6297fcddf912 by R David Murray in branch 'default':
Merge
R. David Murray added the comment:
Benjamin reviewed the patch and pointed out that the settrace state needed to
be restored in the test, so I fixed that when I committed it.
Thanks Ingrid and Brendan.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open -
ingrid added the comment:
Thank you, r.david.murray. I have updated the patch with your suggestions
included.
--
Added file: http://bugs.python.org/file29917/issue17413.patch
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Thanks Ingrid and Mark. The patch looks good; I put a couple of FYI comments
on the review.
I'm pretty sure this patch is correct, but I'd like someone with more
experience modifying the ceval loop to confirm, so I'm nosying Benjamin.
--
nosy:
ingrid added the comment:
It seems that settrace works normally when an exception is raised in the python
code with the raise keyword. If an exception is raised in the C code, settrace
breaks as the C code passes all exceptions as strings. To fix this issue we
just added a line to normalize
Changes by ingrid h...@ingridcheung.com:
--
nosy: +bmac
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17413
___
___
Python-bugs-list mailing list
Helmut Jarausch added the comment:
The problem is caused by the new format_exception in Python's traceback.py
file. It reads
def format_exception(etype, value, tb, limit=None, chain=True):
list = []
if chain:
values = _iter_chain(value, tb)
else:
values = [(value, tb)]
for
R. David Murray added the comment:
Because the second argument to format_traceback is supposed to be (is
documented to be) an exception object. The fact that it used to work anyway in
Python2 if you passed a string was an accident of the implementation.
Likewise, settrace is documented to
Andreas Kloeckner added the comment:
Thanks for the suggestion. Since 3.2 and 3.3 will be with us for a while, I've
implemented the workaround you've suggested. Works, too. :)
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
It looks like a bug in the tracing machinery that has only been revealed by the
changes to how tracebacks are interpreted in python3. It should be a
relatively simple fix, but I wonder if there is existing code that depends on
the second argument getting
Changes by Aaron Meurer asmeu...@gmail.com:
--
nosy: +Aaron.Meurer
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17413
___
___
Python-bugs-list
11 matches
Mail list logo
